Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1244621
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH net-next v2 1/2] hisilicon net: removes the once HANDEL_TX_MSG macro |
| Date | 2015-10-12 14:00 +0200 |
| Message-ID | <qiJVM-6sh-5@gated-at.bofh.it> (permalink) |
| References | <qiBER-35s-3@gated-at.bofh.it> <qiBYd-3rM-13@gated-at.bofh.it> <qiC7T-3CH-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Monday 12 October 2015 11:38:24 huangdaode wrote: > On 2015/10/12 11:24, Joe Perches wrote: > > Hello Huang. > > > > On Mon, 2015-10-12 at 11:23 +0800, huangdaode wrote: > >> This patch changes the code style to make the code more simple. > >> also removes the once used HNADEL_TX_MSG macro, according to the > > HANDEL_TX_MSG typo > > > >> review comments from Joe Perches. > >> > >> Signed-off-by: huangdaode <huangdaode@hisilicon.com> > >> Reviewed-by: Joe Perches <joe@perches.com> > > I didn't review this. > > ' > Hi Joe > please refer to http://lists.openwall.net/netdev/2015/10/11/61 You should only add the "Reviewed-by" tag to a commit message if the person you are adding replied with this explicitly. Don't add it just because someone gave feedback. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH net-next v2 1/2] hisilicon net: removes the once HANDEL_TX_MSG macro huangdaode <huangdaode@hisilicon.com> - 2015-10-12 05:10 +0200
Re: [PATCH net-next v2 1/2] hisilicon net: removes the once HANDEL_TX_MSG macro Joe Perches <joe@perches.com> - 2015-10-12 05:30 +0200
Re: [PATCH net-next v2 1/2] hisilicon net: removes the once HANDEL_TX_MSG macro huangdaode <huangdaode@hisilicon.com> - 2015-10-12 05:40 +0200
Re: [PATCH net-next v2 1/2] hisilicon net: removes the once HANDEL_TX_MSG macro Arnd Bergmann <arnd@arndb.de> - 2015-10-12 14:00 +0200
Re: [PATCH net-next v2 1/2] hisilicon net: removes the once HANDEL_TX_MSG macro Arnd Bergmann <arnd@arndb.de> - 2015-10-12 14:10 +0200
Re: [PATCH net-next v2 1/2] hisilicon net: removes the once HANDEL_TX_MSG macro Joe Perches <joe@perches.com> - 2015-10-12 18:20 +0200
Re: Fwd: Re: [PATCH net-next v2 1/2] hisilicon net: removes the once HANDEL_TX_MSG macro Kenneth Lee <Kenneth-Lee-2012@foxmail.com> - 2015-10-13 15:30 +0200
Re: Fwd: Re: [PATCH net-next v2 1/2] hisilicon net: removes the once HANDEL_TX_MSG macro Arnd Bergmann <arnd@arndb.de> - 2015-10-13 16:30 +0200
Re: Fwd: Re: [PATCH net-next v2 1/2] hisilicon net: removes the once HANDEL_TX_MSG macro Kenneth Lee <Kenneth-Lee-2012@foxmail.com> - 2015-10-15 17:40 +0200
csiph-web