Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1244571

Re: [PATCH 14/14] cgroup: add cgroup_subsys->free() method and use it to fix pids controller

Show all headers | View raw

> pids controller is completely broken in that it uncharges when a task
> exits allowing zombies to escape resource control.  With the recent
> updates, cgroup core now maintains cgroup association till task free
> and pids controller can be fixed by uncharging on free instead of
> exit.

Looks good to me. Out of interest, is there any reason why we still
have ->exit(), given the zombie process edge case? Surely the zombie
process edge case would cause issues with kmemcg and similar
controllers, if they use ->exit() and not ->free()?

-- 
Aleksa Sarai (cyphar)
www.cyphar.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCHSET cgroup/for-4.4] cgroup: make zombies retain cgroup membership and fix pids controller Tejun Heo <tj@kernel.org> - 2015-10-10 05:40 +0200
  [PATCH 12/14] cgroup: make css_set_rwsem a spinlock and rename it to css_set_lock Tejun Heo <tj@kernel.org> - 2015-10-11 15:40 +0200
  [PATCH 13/14] cgroup: keep zombies associated with their original cgroups Tejun Heo <tj@kernel.org> - 2015-10-11 15:40 +0200
    [PATCH v2 13/14] cgroup: keep zombies associated with their original  cgroups Tejun Heo <tj@kernel.org> - 2015-10-12 19:50 +0200
  [PATCH 11/14] cgroup: don't hold css_set_rwsem across css task iteration Tejun Heo <tj@kernel.org> - 2015-10-11 15:40 +0200
    [PATCH v2 11/14] cgroup: don't hold css_set_rwsem across css task  iteration Tejun Heo <tj@kernel.org> - 2015-10-15 03:40 +0200
  [PATCH 14/14] cgroup: add cgroup_subsys->free() method and use it to fix pids controller Tejun Heo <tj@kernel.org> - 2015-10-11 15:40 +0200
    Re: [PATCH 14/14] cgroup: add cgroup_subsys->free() method and use it  to fix pids controller Aleksa Sarai <cyphar@cyphar.com> - 2015-10-12 12:30 +0200
      Re: [PATCH 14/14] cgroup: add cgroup_subsys->free() method and use  it to fix pids controller Tejun Heo <tj@kernel.org> - 2015-10-12 17:30 +0200
  Re: [PATCHSET cgroup/for-4.4] cgroup: make zombies retain cgroup  membership and fix pids controller Tejun Heo <tj@kernel.org> - 2015-10-15 03:40 +0200
    Re: [PATCHSET cgroup/for-4.4] cgroup: make zombies retain cgroup  membership and fix pids controller Tejun Heo <tj@kernel.org> - 2015-10-15 22:50 +0200

csiph-web