Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1244566

Re: [PATCH v2 2/3] irqchip: irq-mips-gic: Provide function to map GIC user section

Show all headers | View raw

On Mon, 12 Oct 2015, Marc Zyngier wrote:
> On 12/10/15 10:40, Markos Chandras wrote:
> > From: Alex Smith <alex.smith@imgtec.com>
> > 
> > The GIC provides a "user-mode visible" section containing a mirror of
> > the counter registers which can be mapped into user memory. This will
> > be used by the VDSO time function implementations, so provide a
> > function to map it in.

<SNIP>
 
> 
> This looks much better than the previous version (though I cannot find
> the two other patches on LKML just yet).

Yes, it looks better. But I really have to ask the question why we are
trying to pack the world and somemore into an irq chip driver. We
already have the completely misplaced gic_read_count() there.

While I understand that all of this is in the GIC block at least
according to the documentation, technically it's different hardware
blocks. And logically its different as well.

So why not describe the various blocks (interrupt controller, timer,
shadow timer) as separate entities in the device tree and let each
subsystem look them up on their own. This cross subsystem hackery is
just horrible and does not buy anything except merge dependencies and
other avoidable hassle.

Thoughts?

Thanks,

	tglx


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 2/3] irqchip: irq-mips-gic: Provide function to map GIC user section Markos Chandras <markos.chandras@imgtec.com> - 2015-10-12 11:50 +0200
  Re: [PATCH v2 2/3] irqchip: irq-mips-gic: Provide function to map  GIC user section Marc Zyngier <marc.zyngier@arm.com> - 2015-10-12 12:00 +0200
    Re: [PATCH v2 2/3] irqchip: irq-mips-gic: Provide function to map  GIC user section Thomas Gleixner <tglx@linutronix.de> - 2015-10-12 12:20 +0200
      Re: [PATCH v2 2/3] irqchip: irq-mips-gic: Provide function to map GIC  user section Qais Yousef <qais.yousef@imgtec.com> - 2015-10-15 11:40 +0200
        Re: [PATCH v2 2/3] irqchip: irq-mips-gic: Provide function to map  GIC user section Thomas Gleixner <tglx@linutronix.de> - 2015-10-15 12:20 +0200

csiph-web