Re: [PATCH net-next] RDS: Invoke ->laddr_check() in rds_bind() for explicitly bound transports.

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!weretis.net!feeder4.news.weretis.net!feeder1.news.weretis.net!newsfeed.CARNet.hr!news.spin.it!bofh.it!news.nic.it!robomod
From	"santosh.shilimkar@oracle.com" <santosh.shilimkar@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH net-next] RDS: Invoke ->laddr_check() in rds_bind() for explicitly bound transports.
Date	Mon, 12 Oct 2015 04:30:02 +0200
Message-ID	<qiB2a-25v-3@gated-at.bofh.it> (permalink)
References	<qivJ8-2Fs-17@gated-at.bofh.it>
X-Original-To	Sowmini Varadhan <sowmini.varadhan@oracle.com>, netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Organization	Oracle Corporation
User-Agent	Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:38.0) Gecko/20100101 Thunderbird/38.3.0
MIME-Version	1.0
Content-Type	text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding	7bit
X-Source-IP	userv0021.oracle.com [156.151.31.71]
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	41
X-Original-Cc	davem@davemloft.net, rds-devel@oss.oracle.com, ajaykumar.hotchandani@oracle.com, igor.maximov@oracle.com
X-Original-Date	Sun, 11 Oct 2015 19:29:23 -0700
X-Original-Message-ID	<561B1B03.5060206@oracle.com>
X-Original-References	<20151011204603.GA14646@oracle.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1244341

Show key headers only | View raw

On 10/11/15 1:46 PM, Sowmini Varadhan wrote:
>
> The IP address passed to rds_bind() should be vetted by the
> transport's ->laddr_check() for a previously bound transport.
> This needs to be done to avoid cases where, for example,
> the application has asked for an IB transport,
> but the IP address passed to bind is only usable on
> ethernet interfaces.
>
Right. Probably it should go into stable as well.

> Signed-off-by: Sowmini Varadhan <sowmini.varadhan@oracle.com>
> ---
>   net/rds/bind.c |    9 ++++++++-
>   1 files changed, 8 insertions(+), 1 deletions(-)
>
> diff --git a/net/rds/bind.c b/net/rds/bind.c
> index bc6b93e..6192566 100644
> --- a/net/rds/bind.c
> +++ b/net/rds/bind.c
> @@ -196,7 +196,14 @@ int rds_bind(struct socket *sock, struct sockaddr *uaddr, int addr_len)
>   		goto out;
>
>   	if (rs->rs_transport) { /* previously bound */
> -		ret = 0;
Minor comment. If you retain above line you can drop the below else.
> +		trans = rs->rs_transport;
> +		if (trans->laddr_check(sock_net(sock->sk),
> +				       sin->sin_addr.s_addr) != 0) {
> +			ret = -ENOPROTOOPT;
> +			rds_remove_bound(rs);
> +		} else {
> +			ret = 0;
> +		}

Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH net-next] RDS: Invoke ->laddr_check() in rds_bind() for  explicitly bound transports. Sowmini Varadhan <sowmini.varadhan@oracle.com> - 2015-10-11 22:50 +0200
  Re: [PATCH net-next] RDS: Invoke ->laddr_check() in rds_bind() for  explicitly bound transports. "santosh.shilimkar@oracle.com" <santosh.shilimkar@oracle.com> - 2015-10-12 04:30 +0200
  Re: [PATCH net-next] RDS: Invoke ->laddr_check() in rds_bind() for  explicitly bound transports. David Miller <davem@davemloft.net> - 2015-10-13 13:10 +0200

csiph-web