Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1244339

Re: staging: wilc1000: WILC1000_DYNAMICALLY_ALLOCATE_MEMROY

Show all headers | View raw

On 2015년 10월 09일 03:47, Greg KH wrote:
> On Thu, Oct 08, 2015 at 09:29:35PM +0300, Stanislav Kholmanskikh wrote:
>> Hi!
>>
>> I noticed that drivers/staging/wilc1000/Kconfic defines:
>>
>> config WILC1000_DYNAMICALLY_ALLOCATE_MEMROY
>>          bool "Dynamically allocate memory in real time"
>>          ---help---
>>            This choice supports dynamic allocation of the memory
>>            for the receive buffer. The driver will allocate the RX buffer
>>            when it is required.
>>
>>
>> "MEMROY" looks suspicious. Is it a typo (MEMORY?) or by intent?
> Probably a typo, but be sure to see if it lines up with what the code
> expects before changing anything.
>
> Ideally in the end this option should be removed as the driver should
> only do dynamic allocation, no static allocation should be needed.

I agree with Greg's opinion. The team is now restructuring the driver and they will be removed and changed.

Thanks for your valuable opinion,

Tony.

>
> thanks,
>
> greg k-h

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

staging: wilc1000: WILC1000_DYNAMICALLY_ALLOCATE_MEMROY Stanislav Kholmanskikh <kholmanskikh.s.s@gmail.com> - 2015-10-08 20:30 +0200
  Re: staging: wilc1000: WILC1000_DYNAMICALLY_ALLOCATE_MEMROY Greg KH <gregkh@linuxfoundation.org> - 2015-10-08 20:50 +0200
    [PATCH] staging: wilc1000: typo in WILC1000_DYNAMICALLY_ALLOCATE_MEMROY Stanislav Kholmanskikh <kholmanskikh.s.s@gmail.com> - 2015-10-09 20:20 +0200
      Re: [PATCH] staging: wilc1000: typo in  WILC1000_DYNAMICALLY_ALLOCATE_MEMROY Dan Carpenter <dan.carpenter@oracle.com> - 2015-10-09 20:30 +0200
        [PATCH] staging: wilc1000: remove WILC1000_DYNAMICALLY_ALLOCATE_MEMROY Stanislav Kholmanskikh <kholmanskikh.s.s@gmail.com> - 2015-10-10 14:50 +0200
          Re: [PATCH] staging: wilc1000: remove  WILC1000_DYNAMICALLY_ALLOCATE_MEMROY Greg KH <gregkh@linuxfoundation.org> - 2015-10-13 07:50 +0200
    Re: staging: wilc1000: WILC1000_DYNAMICALLY_ALLOCATE_MEMROY Tony Cho <tony.cho@atmel.com> - 2015-10-12 04:20 +0200
  Re: staging: wilc1000: WILC1000_DYNAMICALLY_ALLOCATE_MEMROY Tony Cho <tony.cho@atmel.com> - 2015-10-12 04:20 +0200

csiph-web