Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1243989
| From | Tillmann Heidsieck <theidsieck@leenox.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 2/2] atm: iphase: fix misleading indention |
| Date | 2015-10-10 21:50 +0200 |
| Message-ID | <qi8jw-2fO-7@gated-at.bofh.it> (permalink) |
| References | <qi8jw-2fO-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Fix a smatch warning:
drivers/atm/iphase.c:1178 rx_pkt() warn: curly braces intended?
The code is correct, the indention is misleading. In case the allocation
of skb fails, we want to skip to the end.
Signed-off-by: Tillmann Heidsieck <theidsieck@leenox.de>
---
drivers/atm/iphase.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/atm/iphase.c b/drivers/atm/iphase.c
index d5010d7a99c3..7d00f2994738 100644
--- a/drivers/atm/iphase.c
+++ b/drivers/atm/iphase.c
@@ -1176,7 +1176,7 @@ static int rx_pkt(struct atm_dev *dev)
if (!(skb = atm_alloc_charge(vcc, len, GFP_ATOMIC))) {
if (vcc->vci < 32)
printk("Drop control packets\n");
- goto out_free_desc;
+ goto out_free_desc;
}
skb_put(skb,len);
// pwang_test
--
2.6.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH 2/2] atm: iphase: fix misleading indention Tillmann Heidsieck <theidsieck@leenox.de> - 2015-10-10 21:50 +0200 Re: [PATCH 2/2] atm: iphase: fix misleading indention David Miller <davem@davemloft.net> - 2015-10-13 04:50 +0200
csiph-web