Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1243958

Re: [PATCH 4/4] Staging: rtl8712: fix warning for placing constant on the right side of test

Show all headers | View raw

On Sat, 10 Oct 2015, Punit Vara wrote:

> This patch is to the rtl871x_ioctl_linux.c file that fixes up following

The entire above line doesn't give any information (except the file name,
but that can easily be seen from what comes just below).  A commit message
that would get to the point (what you did) more quickly could be something
like: "Put constant on the right side of a test.  Problem found using
checkpatch."

julia

> warnings reported by checkpatch.pl:
>
> -Comparisons should place the constant on the right side of the test
>
> Signed-off-by: Punit Vara <punitvara@gmail.com>
> ---
>  drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> index fc1028a..e9852ae 100644
> --- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> +++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> @@ -959,7 +959,7 @@ static int r871x_wx_set_priv(struct net_device *dev,
>  	if (IS_ERR(ext))
>  		return PTR_ERR(ext);
>
> -	if (0 == strcasecmp(ext, "RSSI")) {
> +	if (strcasecmp(ext, "RSSI") == 0) {
>  		/*Return received signal strength indicator in -db for */
>  		/* current AP */
>  		/*<ssid> Rssi xx */
> @@ -976,7 +976,7 @@ static int r871x_wx_set_priv(struct net_device *dev,
>  		} else {
>  			sprintf(ext, "OK");
>  		}
> -	} else if (0 == strcasecmp(ext, "LINKSPEED")) {
> +	} else if (strcasecmp(ext, "LINKSPEED") == 0) {
>  		/*Return link speed in MBPS */
>  		/*LinkSpeed xx */
>  		union iwreq_data wrqd;
> @@ -984,30 +984,30 @@ static int r871x_wx_set_priv(struct net_device *dev,
>  		int mbps;
>
>  		ret_inner = r8711_wx_get_rate(dev, info, &wrqd, extra);
> -		if (0 != ret_inner)
> +		if (ret_inner != 0)
>  			mbps = 0;
>  		else
>  			mbps = wrqd.bitrate.value / 1000000;
>  		sprintf(ext, "LINKSPEED %d", mbps);
> -	} else if (0 == strcasecmp(ext, "MACADDR")) {
> +	} else if (strcasecmp(ext, "MACADDR") == 0) {
>  		/*Return mac address of the station */
>  		/* Macaddr = xx:xx:xx:xx:xx:xx */
>  		sprintf(ext, "MACADDR = %pM", dev->dev_addr);
> -	} else if (0 == strcasecmp(ext, "SCAN-ACTIVE")) {
> +	} else if (strcasecmp(ext, "SCAN-ACTIVE") == 0) {
>  		/*Set scan type to active */
>  		/*OK if successful */
>  		struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
>
>  		pmlmepriv->passive_mode = 1;
>  		sprintf(ext, "OK");
> -	} else if (0 == strcasecmp(ext, "SCAN-PASSIVE")) {
> +	} else if (strcasecmp(ext, "SCAN-PASSIVE") == 0) {
>  		/*Set scan type to passive */
>  		/*OK if successful */
>  		struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
>
>  		pmlmepriv->passive_mode = 0;
>  		sprintf(ext, "OK");
> -	} else if (0 == strncmp(ext, "DCE-E", 5)) {
> +	} else if (strncmp(ext, "DCE-E", 5) == 0) {
>  		/*Set scan type to passive */
>  		/*OK if successful */
>  		r8712_disconnectCtrlEx_cmd(padapter
> @@ -1017,7 +1017,7 @@ static int r871x_wx_set_priv(struct net_device *dev,
>  			, 5000 /*u32 firstStageTO */
>  		);
>  		sprintf(ext, "OK");
> -	} else if (0 == strncmp(ext, "DCE-D", 5)) {
> +	} else if (strncmp(ext, "DCE-D", 5) == 0) {
>  		/*Set scan type to passive */
>  		/*OK if successfu */
>  		r8712_disconnectCtrlEx_cmd(padapter
> --
> 2.5.3
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 4/4] Staging: rtl8712: fix warning for placing constant on the right side of test Punit Vara <punitvara@gmail.com> - 2015-10-10 19:00 +0200
  Re: [PATCH 4/4] Staging: rtl8712: fix warning for placing constant  on the right side of test Julia Lawall <julia.lawall@lip6.fr> - 2015-10-10 19:10 +0200
    Re: [PATCH 4/4] Staging: rtl8712: fix warning for placing constant on  the right side of test punit vara <punitvara@gmail.com> - 2015-10-10 22:00 +0200

csiph-web