Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1242886
| From | "Rustad, Mark D" <mark.d.rustad@intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 3.2 035/107] PCI: Add dev_flags bit to access VPD through function 0 |
| Date | 2015-10-09 02:30 +0200 |
| Message-ID | <qhtJq-2EJ-71@gated-at.bofh.it> (permalink) |
| References | <qhtJp-2EJ-39@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
Ben Hutchings <ben@decadent.org.uk> wrote:
> --- a/include/linux/pci.h
> +++ b/include/linux/pci.h
> @@ -176,6 +176,8 @@ enum pci_dev_flags {
> PCI_DEV_FLAGS_NO_D3 = (__force pci_dev_flags_t) 2,
> /* Provide indication device is assigned by a Virtual Machine Manager */
> PCI_DEV_FLAGS_ASSIGNED = (__force pci_dev_flags_t) 4,
> + /* Get VPD from function 0 VPD */
> + PCI_DEV_FLAGS_VPD_REF_F0 = (__force pci_dev_flags_t) (1 << 8),
> };
>
> enum pci_irq_reroute_variant {
In this hunk I happened to notice the change in how these values are assigned. Should the new value remain (1 << 8) or should it fall in line with the older implementation and simply be 8? Or should it be 256? It depends on which kind of consistency you prefer for the backport.
--
Mark Rustad, Networking Division, Intel Corporation
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 3.2 035/107] PCI: Add dev_flags bit to access VPD through function 0 Ben Hutchings <ben@decadent.org.uk> - 2015-10-09 02:30 +0200
Re: [PATCH 3.2 035/107] PCI: Add dev_flags bit to access VPD through function 0 "Rustad, Mark D" <mark.d.rustad@intel.com> - 2015-10-09 02:30 +0200
Re: [PATCH 3.2 035/107] PCI: Add dev_flags bit to access VPD through function 0 Ben Hutchings <ben@decadent.org.uk> - 2015-10-09 03:30 +0200
Re: [PATCH 3.2 035/107] PCI: Add dev_flags bit to access VPD through function 0 "Rustad, Mark D" <mark.d.rustad@intel.com> - 2015-10-09 19:10 +0200
csiph-web