Re: [PATCH v5] clk: bcm2835: Add support for programming the audio domain clocks.

From	Eric Anholt <eric@anholt.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5] clk: bcm2835: Add support for programming the audio domain clocks.
Date	2015-10-09 01:50 +0200
Message-ID	<qht6G-1GB-9@gated-at.bofh.it> (permalink)
References	<qgLIl-6JQ-3@gated-at.bofh.it> <qh7IR-4B7-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Stephen Boyd <sboyd@codeaurora.org> writes:

> On 10/06, Eric Anholt wrote:
>> diff --git a/drivers/clk/bcm/clk-bcm2835.c b/drivers/clk/bcm/clk-bcm2835.c
>> index dd295e4..b4d4421 100644
>> --- a/drivers/clk/bcm/clk-bcm2835.c
>> +++ b/drivers/clk/bcm/clk-bcm2835.c
>> @@ -17,10 +17,273 @@
>>  #include <linux/clk-provider.h>
>>  #include <linux/clkdev.h>
>>  #include <linux/clk/bcm2835.h>
>> +#include <linux/module.h>
>>  #include <linux/of.h>
>> +#include <linux/of_address.h>
>> +#include <linux/platform_device.h>
>> +#include <dt-bindings/clock/bcm2835.h>
>
> Please include slab.h for the kzalloc usage

OK, I think I've done all of your feedback now, as well as Stephen
Warren's.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v5] clk: bcm2835: Add support for programming the audio  domain clocks. Stephen Boyd <sboyd@codeaurora.org> - 2015-10-08 03:00 +0200
  Re: [PATCH v5] clk: bcm2835: Add support for programming the audio domain clocks. Eric Anholt <eric@anholt.net> - 2015-10-09 01:50 +0200

csiph-web