Re: [PATCH 2/3] slab_common: clear pointers to per memcg caches on destroy

From	Andrew Morton <akpm@linux-foundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/3] slab_common: clear pointers to per memcg caches on destroy
Date	2015-10-08 23:20 +0200
Message-ID	<qhqLw-6Te-5@gated-at.bofh.it> (permalink)
References	<qhlVv-8s5-3@gated-at.bofh.it> <qhlVv-8s5-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 8 Oct 2015 19:02:40 +0300 Vladimir Davydov <vdavydov@virtuozzo.com> wrote:

> Currently, we do not clear pointers to per memcg caches in the
> memcg_params.memcg_caches array when a global cache is destroyed with
> kmem_cache_destroy. It is fine if the global cache does get destroyed.
> However, a cache can be left on the list if it still has active objects
> when kmem_cache_destroy is called (due to a memory leak). If this
> happens, the entries in the array will point to already freed areas,
> which is likely to result in data corruption when the cache is reused
> (via slab merging).

It's important that we report these leaks so the kernel bug can get
fixed.  The patch doesn't add such detection and reporting, but it
could do so?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH 2/3] slab_common: clear pointers to per memcg caches on destroy Vladimir Davydov <vdavydov@virtuozzo.com> - 2015-10-08 18:10 +0200
  Re: [PATCH 2/3] slab_common: clear pointers to per memcg caches on  destroy Andrew Morton <akpm@linux-foundation.org> - 2015-10-08 23:20 +0200
    Re: [PATCH 2/3] slab_common: clear pointers to per memcg caches on  destroy Vladimir Davydov <vdavydov@virtuozzo.com> - 2015-10-09 10:10 +0200

csiph-web