Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1242697

Re: [PATCH v2] video: fbdev: add Marvell PXA framebuffer binding

Show all headers | View raw

Rob Herring <robh@kernel.org> writes:

>> The pxafb driver acts today on the subset of registers which are the same across
>> all pxaXXX variants. This is what made me think only one compatible property was
>> required.
>>
>> If I'm wrong, I could add "marvell,pxa3xx-lcdc", is that what you think I should
>> do ?
>
> I would prefer specific compatibles (e.g. marvell,pxa270-lcdc) in
> addition to a generic one. You never know when a specific chip will
> have some quirk even though "the IP is the same".
Okay.

>> And then, when a board maintainer will create a devicetree description, he will
>> write something like :
>>       compatible = "toshiba,ltm0305a776";
>>       compatible = "marvell,pxa2xx-panel";
>
> Drop this compatible.
>
>>       lcd-type = "color-tft";
>>       ...
>>
>> If that's the case, I wonder how to "enforce" that a panel used with
>> marvell,pxa2xx-lcdc (through the of_graph 'port' node) be compatible with
>> marvell,pxa2xx-panel ?
>
> I'm not sure what you mean. Putting the panel into the dts ensures
> that. The FB driver may check for toshiba,ltm0305a776 or a list of
> panels. However, a DRM driver would probably not check that.
>
> Rob
What I mean is that the LDLC controller _must_ be programmmed with the correct
panel type, ie. one register of the LDLC should be set according to this type.

The type is a hardware property of the panel, and yet it is absolutely mandatory
to have it set in the panel.

What I mean is : what is the good way to enforce that this property is set
somewhere in the devicetree description ? Philipp adviced for it to be transfered
to the ldlc description (ie. marvell,pxa2xx-ldlc), while I was thinking of
having it in a panel description.

Cheers.

-- 
Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2] video: fbdev: add Marvell PXA framebuffer binding Rob Herring <robh@kernel.org> - 2015-10-06 15:40 +0200
  Re: [PATCH v2] video: fbdev: add Marvell PXA framebuffer binding Robert Jarzmik <robert.jarzmik@free.fr> - 2015-10-06 21:40 +0200
    Re: [PATCH v2] video: fbdev: add Marvell PXA framebuffer binding Philipp Zabel <philipp.zabel@gmail.com> - 2015-10-08 09:00 +0200
    Re: [PATCH v2] video: fbdev: add Marvell PXA framebuffer binding Rob Herring <robh@kernel.org> - 2015-10-08 15:40 +0200
      Re: [PATCH v2] video: fbdev: add Marvell PXA framebuffer binding Robert Jarzmik <robert.jarzmik@free.fr> - 2015-10-08 21:30 +0200
        Re: [PATCH v2] video: fbdev: add Marvell PXA framebuffer binding Rob Herring <robh@kernel.org> - 2015-10-09 02:50 +0200

csiph-web