Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1242520

Re: [PATCH v4 4/5] PCI: generic: Correct, and avoid overflow, in bus_max calculation.

Show all headers | View raw

On Thursday 08 October 2015 10:02:43 Bjorn Helgaas wrote:
> [+cc Arnd]
> 
> And this one?

Not so good.

> > --- a/Documentation/devicetree/bindings/pci/host-generic-pci.txt
> > +++ b/Documentation/devicetree/bindings/pci/host-generic-pci.txt
> > @@ -34,7 +34,11 @@ Properties of the host controller node:
> >  - #size-cells    : Must be 2.
> >  
> >  - reg            : The Configuration Space base address and size, as accessed
> > -                   from the parent bus.
> > +                   from the parent bus.  The base address corresponds to
> > +                   bus zero, even though the "bus-range" property may specify
> > +                   a different starting bus number.  The driver must only map
> > +                   or access the portion of the Configuration Space that
> > +                   corresponds to the "bus-range"

I thought we had reached an agreement that it is a bad idea to have a 'reg'
property that lists registers belonging to a different device.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v4 4/5] PCI: generic: Correct, and avoid overflow, in  bus_max calculation. Bjorn Helgaas <helgaas@kernel.org> - 2015-10-08 17:10 +0200
  Re: [PATCH v4 4/5] PCI: generic: Correct, and avoid overflow, in bus_max calculation. Arnd Bergmann <arnd@arndb.de> - 2015-10-08 17:20 +0200
    Re: [PATCH v4 4/5] PCI: generic: Correct, and avoid overflow, in  bus_max calculation. Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2015-10-08 19:30 +0200
  Re: [PATCH v4 4/5] PCI: generic: Correct, and avoid overflow, in bus_max calculation. Arnd Bergmann <arnd@arndb.de> - 2015-10-08 17:20 +0200

csiph-web