Re: [PATCH v2] ARM: cns3xxx: pci: avoid potential stack overflow

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] ARM: cns3xxx: pci: avoid potential stack overflow
Date	2015-10-08 16:40 +0200
Message-ID	<qhkwp-6iy-1@gated-at.bofh.it> (permalink)
References	<prRth-1Zg-63@gated-at.bofh.it> <qh3cf-6Lp-23@gated-at.bofh.it> <qhgja-iz-41@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thursday 08 October 2015 12:03:18 Krzysztof Hałasa wrote:
> Hi,
> 
> Arnd Bergmann <arnd@arndb.de> writes:
> 
> > With those two changes in place, we no longer need the fake
> > pci_sys_data/pci_bus structures for faking config space writes,
> > and the stack usage goes down as well.
> 
> >  arch/arm/mach-cns3xxx/pcie.c | 71 +++++++++++++++++++++++++++++----------------------------------------
> 
> I'm ATM unable to test this change, but will do that at some point.
> Meanwhile, I guess there is nothing I can say against this patch.
> Thanks.
> 
> Acked-by: Krzysztof Hałasa <khalasa@piap.pl>
> 

Thanks! I've queued it up in next/fixes-non-critical for linux-4.4
now, if you find something wrong later, we can revert or fix up.

There is no urgency for this one, especially since you still want to
test it, so no reason to put it in 4.3.

This was the last pre-2015 build warning for the ARM defconfigs
and allmodconfig, all remaining warnings are regressions or new
code, and I've submitted patches for those. Let's see if we can
get to a warning-free kernel build in 4.4.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] ARM: cns3xxx: pci: avoid potential stack overflow Arnd Bergmann <arnd@arndb.de> - 2015-10-07 22:10 +0200
  [PATCH v2] ARM: cns3xxx: pci: avoid potential stack overflow Arnd Bergmann <arnd@arndb.de> - 2015-10-07 22:10 +0200
    Re: [PATCH v2] ARM: cns3xxx: pci: avoid potential stack overflow khalasa@piap.pl (Krzysztof Hałasa) - 2015-10-08 12:10 +0200
      Re: [PATCH v2] ARM: cns3xxx: pci: avoid potential stack overflow Arnd Bergmann <arnd@arndb.de> - 2015-10-08 16:40 +0200

csiph-web