Re: [PATCH 3/5] block: nvme-core: simplify ida usage

From	Keith Busch <keith.busch@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/5] block: nvme-core: simplify ida usage
Date	2015-10-08 16:30 +0200
Message-ID	<qhkmK-67a-19@gated-at.bofh.it> (permalink)
References	<qeRfc-4FF-13@gated-at.bofh.it> <qeRfc-4FF-13@gated-at.bofh.it> <qeRoS-56r-29@gated-at.bofh.it> <qf5Bx-ps-33@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, 2 Oct 2015, Johannes Thumshirn wrote:
> Lee Duncan <lduncan@suse.com> writes:
>> Simplify ida index allocation and removal by
>> using the ida_simple_* helper functions.

Looks good to me. Just one comment:

>>  static void nvme_release_instance(struct nvme_dev *dev)
>>  {
>>  	spin_lock(&dev_list_lock);
>> -	ida_remove(&nvme_instance_ida, dev->instance);
>> +	ida_simple_remove(&nvme_instance_ida, dev->instance);
>>  	spin_unlock(&dev_list_lock);

No harm from taking the nvme spin lock here, but it's not necessary with
the simple interface.

> Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 3/5] block: nvme-core: simplify ida usage Keith Busch <keith.busch@intel.com> - 2015-10-08 16:30 +0200

csiph-web