Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1242395

Re: [PATCH net-next 0/6] net: dsa: push switchdev prepare phase in FDB ops

Show all headers | View raw

Hi Jiri, David,

On Oct. Thursday 08 (41) 03:47 PM, Jiri Pirko wrote:
> Thu, Oct 08, 2015 at 03:32:51PM CEST, vivien.didelot@savoirfairelinux.com wrote:
> >Hi David,
> >
> >On Oct. Thursday 08 (41) 05:28 AM, David Miller wrote:
> >> From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
> >> Date: Wed,  7 Oct 2015 19:48:25 -0400
> >> 
> >> > The first 3 patches removes the dsa.h include from linux/netdevice.h, which
> >> > broke the inclusion of switchdev.h in dsa.h.
> >> 
> >> I still don't agree with bloating up struct netdevice just to deal with
> >> an include file ordering issue, sorry.
> >
> >Yes, I just saw your reply on the first version. I will resend the
> >patchset with the forward declarations instead.
> >
> >But looking at the issue that Jiri and the kbuild bot pointed out
> >earlier in the thread, we must agree that having the DSA header in
> >netdevice.h is wrong.
> >
> >There are 2 points to note here:
> >
> >* checking a "rcv" member of a DSA-specific structure to anwser the
> >  question "does this interface uses hardware-inserted tag?" is not
> >  generic and not robust at all.
> >
> >* the "dsa_ptr" of net_device is just used to access the dsa_switch_tree
> >  from DSA packet_type receive functions. There must be another way to
> >  pass it, maybe from a netdev_priv or the packet_type->af_packet_priv?
> 
> I sent previously patch for this:
> http://patchwork.ozlabs.org/patch/336940/
> So now my patch would have another user :)

Your patch makes sense. It will reduce the bloating of net_device that
David is talking about. I would also suspect that other <protocol>_ptr
members of the structure are only used in the context of packet_type.

> Vivien, I will refresh the patch and send it to you, the you can
> use the priv by dsa and send my patch along with your patchset. How does
> that sound?

Sure, sounds good.

Thanks,
-v
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net-next 0/6] net: dsa: push switchdev prepare phase in FDB ops Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2015-10-08 02:00 +0200
  [PATCH net-next 4/6] net: dsa: add port_fdb_prepare Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2015-10-08 02:00 +0200
    Re: [PATCH net-next 4/6] net: dsa: add port_fdb_prepare Andrew Lunn <andrew@lunn.ch> - 2015-10-08 02:30 +0200
      Re: [PATCH net-next 4/6] net: dsa: add port_fdb_prepare Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2015-10-08 15:10 +0200
        Re: [PATCH net-next 4/6] net: dsa: add port_fdb_prepare Andrew Lunn <andrew@lunn.ch> - 2015-10-08 17:10 +0200
    Re: [PATCH net-next 4/6] net: dsa: add port_fdb_prepare Scott Feldman <sfeldma@gmail.com> - 2015-10-08 08:20 +0200
  [PATCH net-next 3/6] net: remove dsa.h include from linux/netdevice.h Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2015-10-08 02:00 +0200
    Re: [PATCH net-next 3/6] net: remove dsa.h include from  linux/netdevice.h Jiri Pirko <jiri@resnulli.us> - 2015-10-08 11:20 +0200
      Re: [PATCH net-next 3/6] net: remove dsa.h include from linux/netdevice.h Wei Xu <xuwei5@hisilicon.com> - 2015-10-08 12:40 +0200
      Re: [PATCH net-next 3/6] net: remove dsa.h include from  linux/netdevice.h Jiri Pirko <jiri@resnulli.us> - 2015-10-08 14:20 +0200
        Re: [PATCH net-next 3/6] net: remove dsa.h include from linux/netdevice.h huangdaode <huangdaode@hisilicon.com> - 2015-10-08 14:50 +0200
  Re: [PATCH net-next 0/6] net: dsa: push switchdev prepare phase in  FDB ops David Miller <davem@davemloft.net> - 2015-10-08 14:20 +0200
    Re: [PATCH net-next 0/6] net: dsa: push switchdev prepare phase in  FDB ops Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2015-10-08 15:40 +0200
      Re: [PATCH net-next 0/6] net: dsa: push switchdev prepare phase in  FDB ops Jiri Pirko <jiri@resnulli.us> - 2015-10-08 15:50 +0200
        Re: [PATCH net-next 0/6] net: dsa: push switchdev prepare phase in  FDB ops Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2015-10-08 16:20 +0200

csiph-web