Re: [PATCH 05/17] fs/exofs: remove unnecessary new_valid_dev check

Path	csiph.com!goblin3!goblin1!goblin.stu.neva.ru!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Yaowei Bai <bywxiaobai@163.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 05/17] fs/exofs: remove unnecessary new_valid_dev check
Date	Thu, 08 Oct 2015 14:40:02 +0200
Message-ID	<qhiEh-3AP-1@gated-at.bofh.it> (permalink)
References	<qdGOS-Rc-7@gated-at.bofh.it> <qdH8d-1eq-1@gated-at.bofh.it> <qe3s8-85D-49@gated-at.bofh.it>
X-Original-To	Boaz Harrosh <ooo@electrozaur.com>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=Date:From:Subject:Message-ID:MIME-Version; bh=xjYpl 9in6ceuqj9F9iM0QRuhLRaRUKdNKeJgeA1Ubs4=; b=Dy3lUny5jmZAKaCvTvCva 0aL1WMdaL/hFS+++5Yjwj5UGY+OA83MujF4U4AwyrqckLLft3f9xOfo0aNmXT/c9 nUe2qJNAjzoc3Bq7OdxYwE9Yuuevsta5X8Gcs4XNtEwW9FkxgNx6LZLclQ+V5HPn aeOyP1HcVjpQU99GmoseKc=
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.21 (2010-09-15)
X-Cm-Transid	EsCowEDZH1a6YRZWaL_ZBQ--.2977S3
X-Coremail-Antispam	1Uf129KBjvdXoW7Xr1ruF17Gr18GrWUtFWfAFb_yoWkurc_Wr Wjyw48Zr15Xw1xAan5Kw15Xr9Y9Fs0grW8J343tr43XFn3tFZ5ZaykWws5AFy7uF48GFZx uryF9a45Gr1j9jkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUnJ8nUUUUUU==
X-Originating-IP	[58.208.67.211]
X-Cm-Senderinfo	xe1z5x5dretxi6rwjhhfrp/1tbiLRyNT1SIKo3+qgAAsc
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	48
Organization	linux.* mail to news gateway
X-Original-Cc	viro@zeniv.linux.org.uk, bhalevy@primarydata.com, osd-dev@open-osd.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date	Thu, 8 Oct 2015 20:29:46 +0800
X-Original-Message-ID	<20151008122946.GB3711@bbox>
X-Original-References	<1443446807-4838-1-git-send-email-bywxiaobai@163.com> <1443447836-5178-1-git-send-email-bywxiaobai@163.com> <560A9672.9@electrozaur.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1242301

Show key headers only | View raw

On Tue, Sep 29, 2015 at 04:47:30PM +0300, Boaz Harrosh wrote:
> On 09/28/2015 04:43 PM, Yaowei Bai wrote:
> > As new_valid_dev always returns 1, so !new_valid_dev check is not
> > needed, remove it.
> > 
> > Signed-off-by: Yaowei Bai <bywxiaobai@163.com>
> 
> ACK-by: Boaz Harrosh <ooo@electrozaur.com>
> 
> Please submit this through some General tree like the vfs or mm-tree

Sorry for delay reply. There's something wrong with my mailbox and
i lost your last recent reply. And i just want to say i will follow
your advice to send this patchset to Morton and once he takes it i'll
send another patch to remove new_valid_dev() at all. Thanks.

Thanks
Bai

> 
> Thanks
> Boaz
> 
> > ---
> >  fs/exofs/namei.c | 3 ---
> >  1 file changed, 3 deletions(-)
> > 
> > diff --git a/fs/exofs/namei.c b/fs/exofs/namei.c
> > index 09a6bb1..994e078 100644
> > --- a/fs/exofs/namei.c
> > +++ b/fs/exofs/namei.c
> > @@ -80,9 +80,6 @@ static int exofs_mknod(struct inode *dir, struct dentry *dentry, umode_t mode,
> >  	struct inode *inode;
> >  	int err;
> >  
> > -	if (!new_valid_dev(rdev))
> > -		return -EINVAL;
> > -
> >  	inode = exofs_new_inode(dir, mode);
> >  	err = PTR_ERR(inode);
> >  	if (!IS_ERR(inode)) {
> > 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 05/17] fs/exofs: remove unnecessary new_valid_dev check Yaowei Bai <bywxiaobai@163.com> - 2015-10-08 14:40 +0200

csiph-web