Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1242191

Re: [PATCH v7 2/9] Input: goodix - reset device at init

Show all headers | View raw

On Thursday 08 October 2015 13:19:28 Irina Tirdea wrote:
> After power on, it is recommended that the driver resets the device.
> The reset procedure timing is described in the datasheet and is used
> at device init (before writing device configuration) and
> for power management. It is a sequence of setting the interrupt
> and reset pins high/low at specific timing intervals. This procedure
> also includes setting the slave address to the one specified in the
> ACPI/device tree.
> 
> This is based on Goodix datasheets for GT911 and GT9271 and on Goodix
> driver gt9xx.c for Android (publicly available in Android kernel
> trees for various devices).
> 
> For reset the driver needs to control the interrupt and
> reset gpio pins (configured through ACPI/device tree). For devices
> that do not have the gpio pins declared, the functionality depending
> on these pins will not be available, but the device can still be used
> with basic functionality.
> 
> For both device tree and ACPI, the interrupt gpio pin configuration is
> read from the "irq-gpio" property and the reset pin configuration is
> read from the "reset-gpio" property. For ACPI 5.1, named properties
> can be specified using the _DSD section. If there is no _DSD section
> in the ACPI table, the driver will fall back to using indexed gpio
> pins declared in the _CRS section.

Would it help to use a plain "gpios" property here to always look
up the lines by index?

> +/*
> + * Some platforms specify the gpio pins for interrupt and reset properly
> + * in ACPI, but cannot use the interrupt pin as output due to their specific
> + * HW configuration.
> + */
> +static const struct dmi_system_id goodix_no_gpio_pins_support[] = {
> +#if defined(CONFIG_DMI) && defined(CONFIG_X86)
> +	{
> +		.ident = "Onda v975w",
> +		.matches = {
> +			DMI_MATCH(DMI_BIOS_VENDOR, "American Megatrends Inc."),
> +			DMI_MATCH(DMI_PRODUCT_UUID,
> +				  "03000200-0400-0500-0006-000700080009"),
> +			DMI_MATCH(DMI_BOARD_VENDOR, "AMI Corporation"),
> +			DMI_MATCH(DMI_BOARD_NAME, "Aptio CRB"),
> +		}
> +	},

I think lists like this in drivers should be avoided if at all possible,
it just leads to other people adding their platform in the lists as
opposed to fixing their boot loaders.

Can you find another way to detect at runtime whether it works, and
print a warning if it doesn't? If there is no way to detect that kind
of device, we should probably have another property that the driver
can read to determine this, so we can avoid adding each system here.

> +	/* HIGH: 0x28/0x29, LOW: 0xBA/0xBB */
> +	error = gpiod_direction_output(ts->gpiod_int, ts->client->addr == 0x14);
> +	if (error)
> +		return error;

If the "interrupt" gpio is used as an output, maybe it has the wrong
name? Is that the name from the goodix datasheet (that would be ok)
or something you picked?

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v7 0/9] Goodix touchscreen enhancements Irina Tirdea <irina.tirdea@intel.com> - 2015-10-08 12:30 +0200
  [PATCH v7 4/9] Input: goodix - add power management support Irina Tirdea <irina.tirdea@intel.com> - 2015-10-08 12:30 +0200
  [PATCH v7 6/9] Input: goodix - add support for ESD Irina Tirdea <irina.tirdea@intel.com> - 2015-10-08 12:30 +0200
  [PATCH v7 7/9] Input: goodix - add sysfs interface to dump config Irina Tirdea <irina.tirdea@intel.com> - 2015-10-08 12:30 +0200
  [PATCH v7 3/9] Input: goodix - write configuration data to device Irina Tirdea <irina.tirdea@intel.com> - 2015-10-08 12:30 +0200
    Re: [PATCH v7 3/9] Input: goodix - write configuration data to device Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2015-10-14 09:00 +0200
  [PATCH v7 1/9] Input: goodix - use actual config length for each device type Irina Tirdea <irina.tirdea@intel.com> - 2015-10-08 12:30 +0200
  [PATCH v7 8/9] Input: goodix - add runtime power management support Irina Tirdea <irina.tirdea@intel.com> - 2015-10-08 12:30 +0200
  [PATCH v7 5/9] Input: goodix - use goodix_i2c_write_u8 instead of i2c_master_send Irina Tirdea <irina.tirdea@intel.com> - 2015-10-08 12:30 +0200
  [PATCH v7 9/9] Input: goodix - sort includes using inverse Xmas tree order Irina Tirdea <irina.tirdea@intel.com> - 2015-10-08 12:30 +0200
  [PATCH v7 2/9] Input: goodix - reset device at init Irina Tirdea <irina.tirdea@intel.com> - 2015-10-08 12:30 +0200
    Re: [PATCH v7 2/9] Input: goodix - reset device at init Arnd Bergmann <arnd@arndb.de> - 2015-10-08 13:00 +0200
      Re: [PATCH v7 2/9] Input: goodix - reset device at init Bastien Nocera <hadess@hadess.net> - 2015-10-08 13:40 +0200
      RE: [PATCH v7 2/9] Input: goodix - reset device at init "Tirdea, Irina" <irina.tirdea@intel.com> - 2015-10-08 14:20 +0200
        Re: [PATCH v7 2/9] Input: goodix - reset device at init Arnd Bergmann <arnd@arndb.de> - 2015-10-08 15:10 +0200
          RE: [PATCH v7 2/9] Input: goodix - reset device at init "Tirdea, Irina" <irina.tirdea@intel.com> - 2015-10-08 16:20 +0200
  Re: [PATCH v7 0/9] Goodix touchscreen enhancements Arnd Bergmann <arnd@arndb.de> - 2015-10-08 13:10 +0200
    RE: [PATCH v7 0/9] Goodix touchscreen enhancements "Tirdea, Irina" <irina.tirdea@intel.com> - 2015-10-08 14:20 +0200

csiph-web