Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1242092

Re: [PATCH v2] x86, bitops, variable_test_bit should return 1 not -1 on a match

Show all headers | View raw

* Prarit Bhargava <prarit@redhat.com> wrote:

> re-ping on this.  Just making sure this wasn't dropped on the floor.

So I didn't apply it back when I saw your patch because I didn't see where you 
addressed/analyzed the second paragraph of hpa's review:

  "The downside with set is that it only sets a single byte, the upside is that it 
   always outputs 0 or 1, and apparently if the output variable is your bool gcc 
   can use that for optimization."

That's a valid concern and should be addressed.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2] x86, bitops, variable_test_bit should return 1 not  -1 on a match Prarit Bhargava <prarit@redhat.com> - 2015-10-08 01:30 +0200
  Re: [PATCH v2] x86, bitops, variable_test_bit should return 1 not -1  on a match Ingo Molnar <mingo@kernel.org> - 2015-10-08 11:00 +0200

csiph-web