Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1241971

[PATCH 5/5] thermal: exynos: Directly return 0 instead of using local ret variable

Show all headers | View raw

The 'ret' variable in exynos5440_tmu_initialize() is initialized to 0
and returned as is. Replace it with direct return statement. This also
fixes coccinelle warning:
drivers/thermal/samsung/exynos_tmu.c:611:5-8: Unneeded variable: "ret". Return "0" on line 654

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
---
 drivers/thermal/samsung/exynos_tmu.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c
index 1af7ea8dda71..f340e6edcb49 100644
--- a/drivers/thermal/samsung/exynos_tmu.c
+++ b/drivers/thermal/samsung/exynos_tmu.c
@@ -608,7 +608,7 @@ static int exynos5440_tmu_initialize(struct platform_device *pdev)
 {
 	struct exynos_tmu_data *data = platform_get_drvdata(pdev);
 	unsigned int trim_info = 0, con, rising_threshold;
-	int ret = 0, threshold_code;
+	int threshold_code;
 	int crit_temp = 0;
 
 	/*
@@ -651,7 +651,8 @@ static int exynos5440_tmu_initialize(struct platform_device *pdev)
 	/* Clear the PMIN in the common TMU register */
 	if (!data->id)
 		writel(0, data->base_second + EXYNOS5440_TMU_PMIN);
-	return ret;
+
+	return 0;
 }
 
 static int exynos7_tmu_initialize(struct platform_device *pdev)
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/5] thermal: exynos: Fix unbalanced regulator disable on probe  failure Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-10-08 07:40 +0200
  [PATCH 5/5] thermal: exynos: Directly return 0 instead of using local  ret variable Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-10-08 07:40 +0200
    Re: [PATCH 5/5] thermal: exynos: Directly return 0 instead of using  local ret variable Alim Akhtar <alim.akhtar@gmail.com> - 2015-10-08 18:50 +0200
  Re: [PATCH 1/5] thermal: exynos: Fix unbalanced regulator disable on  probe failure Alim Akhtar <alim.akhtar@gmail.com> - 2015-10-08 18:50 +0200
    Re: [PATCH 1/5] thermal: exynos: Fix unbalanced regulator disable on  probe failure Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-10-09 13:00 +0200
      Re: [PATCH 1/5] thermal: exynos: Fix unbalanced regulator disable on  probe failure Alim Akhtar <alim.akhtar@gmail.com> - 2015-10-10 03:50 +0200

csiph-web