Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1243789

RE: [PATCH][v3] ACPI / PM: Fix incorrect wakeup irq setting before suspend-to-idle

Show all headers | View raw

Hi,

> From: Chen, Yu C
> Sent: Friday, October 09, 2015 5:50 PM
> 
> Hi, LV
> 
> > From: Zheng, Lv
> > Sent: Friday, October 09, 2015 4:33 PM
> >
> > Hi, Yu
> >
> > > From: Chen, Yu C
> > > Sent: Friday, October 09, 2015 4:20 PM
> > >
> > >
> > >  acpi_status acpi_os_remove_interrupt_handler(u32 irq,
> > > acpi_osd_handler handler)
> >
> > Why don't you rename irq here to gsi to improve the readability?
> > The false naming and the wrong example written for this function are
> > probably the root causes of all other bad code.
> > So if we want to stop people making future mistakes, we need to cleanup
> > ourselves.
> >
> OK, will rewrite in next version.

You can add Acked-by: Lv Zheng <lv.zheng@intel.com>
And don't forget to mark it as a stable material.

One more question is:
Do you want the modules to use "acpi_sci_irq"?
If the answer is no, then please ignore this question.

Thanks and best regards
-Lv 


> 
> > Thanks and best regards
> > -Lv
> >

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH][v3] ACPI / PM: Fix incorrect wakeup irq setting before suspend-to-idle Chen Yu <yu.c.chen@intel.com> - 2015-10-09 10:20 +0200
  RE: [PATCH][v3] ACPI / PM: Fix incorrect wakeup irq setting before  suspend-to-idle "Zheng, Lv" <lv.zheng@intel.com> - 2015-10-09 10:40 +0200
    RE: [PATCH][v3] ACPI / PM: Fix incorrect wakeup irq setting before  suspend-to-idle "Chen, Yu C" <yu.c.chen@intel.com> - 2015-10-09 12:00 +0200
      RE: [PATCH][v3] ACPI / PM: Fix incorrect wakeup irq setting before  suspend-to-idle "Zheng, Lv" <lv.zheng@intel.com> - 2015-10-10 04:30 +0200
      Re: [PATCH][v3] ACPI / PM: Fix incorrect wakeup irq setting before suspend-to-idle "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-10-12 22:00 +0200
        RE: [PATCH][v3] ACPI / PM: Fix incorrect wakeup irq setting before  suspend-to-idle "Chen, Yu C" <yu.c.chen@intel.com> - 2015-10-14 19:50 +0200

csiph-web