Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1243747

Re: [PATCH] namei: results of d_is_negative() should be checked after dentry revalidation

Show all headers | View raw

On Fri, Oct 9, 2015 at 10:44 AM, Trond Myklebust
<trond.myklebust@primarydata.com> wrote:
>
> The issue is that revalidation may cause the dentry to be dropped in NFS
> if, say, the client notes that the directory timestamps have changed.

Ack.

We've had this bug before, where we returned something else than
-ENOCHLD while we were doing RCU lookups. See for example commit
97242f99a013 ("link_path_walk(): be careful when failing with
ENOTDIR").

So in general, we should always (a) either verify all sequence points
or (b) return -ENOCHLD to go into slow mode. The patch seems

However, this thing was explicitly made to be this way by commit
766c4cbfacd8 ("namei: d_is_negative() should be checked before ->d_seq
validation"), so while my gut feel is to consider this fix
ObviouslyCorrect(tm), I will delay it a bit in the hope to get an ACK
and comment from Al about the patch.

Al?

                  Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] namei: results of d_is_negative() should be checked after dentry revalidation Trond Myklebust <trond.myklebust@primarydata.com> - 2015-10-09 19:50 +0200
  Re: [PATCH] namei: results of d_is_negative() should be checked after  dentry revalidation Linus Torvalds <torvalds@linux-foundation.org> - 2015-10-10 02:20 +0200
    Re: [PATCH] namei: results of d_is_negative() should be checked  after dentry revalidation Al Viro <viro@ZenIV.linux.org.uk> - 2015-10-10 03:40 +0200
      Re: [PATCH] namei: results of d_is_negative() should be checked  after dentry revalidation Al Viro <viro@ZenIV.linux.org.uk> - 2015-10-10 19:20 +0200
        Re: [PATCH] namei: results of d_is_negative() should be checked after  dentry revalidation Linus Torvalds <torvalds@linux-foundation.org> - 2015-10-10 19:30 +0200

csiph-web