Re: [PATCH] fbcon: initialize blink interval before calling fb_set_par

From	Benjamin Herrenschmidt <benh@kernel.crashing.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] fbcon: initialize blink interval before calling fb_set_par
Date	2015-10-09 23:20 +0200
Message-ID	<qhNf4-5xo-9@gated-at.bofh.it> (permalink)
References	<qfk7v-4bH-5@gated-at.bofh.it> <qfnyq-Oc-3@gated-at.bofh.it> <qhyzo-1e0-15@gated-at.bofh.it> <qhHt0-5GT-31@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, 2015-10-09 at 15:08 +0000, Scot Doyle wrote:
> Since commit 27a4c827c34ac4256a190cc9d24607f953c1c459
>     fbcon: use the cursor blink interval provided by vt
> 
> a PPC64LE kernel fails to boot when fbcon_add_cursor_timer uses an
> uninitialized ops->cur_blink_jiffies. Prevent by initializing
> in fbcon_init before the call to info->fbops->fb_set_par.

> Reported-and-tested-by: Alistair Popple <alistair@popple.id.au>
> Signed-off-by: Scot Doyle <lkml14@scotdoyle.com>

Please add

CC: <stable@vger.kernel.org> [v4.2]

This bug will cause any machine using fbcon to occasionally fail
to boot due to having a timer callback try to mod_timer with
"jiffies + 0" without an exit condition.

Cheers,
Ben.

> ---
>  drivers/video/console/fbcon.c | 1 +
>  1 file changed, 1 insertion(+) 
> 
> diff --git a/drivers/video/console/fbcon.c
> b/drivers/video/console/fbcon.c
> index 1aaf893..92f3949 100644
> --- a/drivers/video/console/fbcon.c
> +++ b/drivers/video/console/fbcon.c
> @@ -1093,6 +1093,7 @@ static void fbcon_init(struct vc_data *vc, int
> init)
>                 con_copy_unimap(vc, svc);
>  
>         ops = info->fbcon_par;
> +       ops->cur_blink_jiffies = msecs_to_jiffies(vc
> ->vc_cur_blink_ms);
>         p->con_rotate = initial_rotation;
>         set_blitting_type(vc, info);
>  
> -- 
> 2.1.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux
> -fbdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [BUG] RCU stall in cursor_timer_handler Alistair Popple <alistair@popple.id.au> - 2015-10-09 07:40 +0200
  [PATCH] fbcon: initialize blink interval before calling fb_set_par Scot Doyle <lkml14@scotdoyle.com> - 2015-10-09 17:10 +0200
    Re: [PATCH] fbcon: initialize blink interval before calling  fb_set_par Benjamin Herrenschmidt <benh@kernel.crashing.org> - 2015-10-09 23:20 +0200

csiph-web