Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1243641

Re: arm/arm64: GICv2 driver does not have irq_disable implemented

Show all headers | View raw

On Fri, Oct 9, 2015 at 10:52 AM, Thomas Gleixner <tglx@linutronix.de> wrote:
> On Fri, 9 Oct 2015, Duc Dang wrote:
>> Hi Thomas, Marc, Jason and All,
>>
>> In APM ARM64 X-Gene Enet controller driver, we use disable_irq_nosync to
>> disable interrupt before calling __napi_schedule to schedule packet handler
>> to process the Tx/Rx packets.
>
> Which is wrong to begin with. Disable the interrupt at the device
> level not at the interrupt line level.
>
Hi Thomas,

We could not disable the interrupt at Enet controller level due to the
controller limitation. As you said, using  disable_irq_nosync is wrong
but it looks like that the only option that we have.

Do you have any suggestion about different approach that we could try?

> Thanks,
>
>         tglx

Regards,
Duc Dang.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: arm/arm64: GICv2 driver does not have irq_disable implemented Thomas Gleixner <tglx@linutronix.de> - 2015-10-09 20:00 +0200
  Re: arm/arm64: GICv2 driver does not have irq_disable implemented Duc Dang <dhdang@apm.com> - 2015-10-09 22:50 +0200
    Re: arm/arm64: GICv2 driver does not have irq_disable implemented Thomas Gleixner <tglx@linutronix.de> - 2015-10-10 00:00 +0200
      Re: arm/arm64: GICv2 driver does not have irq_disable implemented Duc Dang <dhdang@apm.com> - 2015-10-10 00:30 +0200
        Re: arm/arm64: GICv2 driver does not have irq_disable implemented Duc Dang <dhdang@apm.com> - 2015-10-10 01:40 +0200
      [tip:irq/core] genirq: Add flag to force mask in disable_irq[  _nosync]() tip-bot for Thomas Gleixner <tipbot@zytor.com> - 2015-10-11 11:40 +0200

csiph-web