Re: [PATCH v2 4/5] arm64: Juno: Add support for the PCIe host bridge on Juno R1

From	Rob Herring <robherring2@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 4/5] arm64: Juno: Add support for the PCIe host bridge on Juno R1
Date	2015-10-09 19:50 +0200
Message-ID	<qhJXP-HL-5@gated-at.bofh.it> (permalink)
References	<qhJbr-7Z4-7@gated-at.bofh.it> <qhJbs-7Z4-21@gated-at.bofh.it> <qhJl7-8pE-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Oct 9, 2015 at 12:04 PM, Mark Rutland <mark.rutland@arm.com> wrote:
> On Fri, Oct 09, 2015 at 05:57:28PM +0100, Liviu Dudau wrote:
>> Juno R1 board sports a functional PCIe host bridge that is
>> compliant with the SBSA standard found [1] here. With the right
>> firmware that initialises the XpressRICH3 controller one can
>> use the generic Host Bridge driver to use the PCIe hardware.
>>
>> Signed-off-by: Liviu Dudau <Liviu.Dudau@arm.com>
>>
>> [1] http://infocenter.arm.com/help/topic/com.arm.doc.den0029a/
>> ---
>>  arch/arm64/boot/dts/arm/juno-r1.dts | 20 ++++++++++++++++++++
>>  1 file changed, 20 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/arm/juno-r1.dts b/arch/arm64/boot/dts/arm/juno-r1.dts
>> index c627511..a702a6b 100644
>> --- a/arch/arm64/boot/dts/arm/juno-r1.dts
>> +++ b/arch/arm64/boot/dts/arm/juno-r1.dts
>> @@ -109,7 +109,26 @@
>>
>>       #include "juno-base.dtsi"
>>
>> +     pcie-controller@40000000 {
>> +             compatible = "arm,juno-r1-pcie", "plda,xpressrich3", "pci-host-ecam-generic";
>
> Judging by a PLDA press release [1], it looks like Juno uses
> "XpressRICH3-AXI" [2] rather than "XpressRICH3 for ASIC" [3].
>
> So sorry to bikeshed the name I suggested, but it's probably best to
> s/plda,xpressrich3/plda,xpressrich3-axi/
>
> With that:
>
> Acked-by: Mark Rutland <mark.rutland@arm.com>
>
> I assume that can be fixed up when picking (or prior to a pull) without
> the need to repost.

Also, now these strings need to be documented. :)

I would just adding to the generic host doc.

Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 4/5] arm64: Juno: Add support for the PCIe host bridge on Juno R1 Liviu Dudau <Liviu.Dudau@arm.com> - 2015-10-09 19:00 +0200
  Re: [PATCH v2 4/5] arm64: Juno: Add support for the PCIe host bridge  on Juno R1 Mark Rutland <mark.rutland@arm.com> - 2015-10-09 19:10 +0200
    Re: [PATCH v2 4/5] arm64: Juno: Add support for the PCIe host bridge  on Juno R1 Rob Herring <robherring2@gmail.com> - 2015-10-09 19:50 +0200

csiph-web