Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1243548

RE: [PATCH 0/6] staging: comedi: fix some minor issues with file poll op

Show all headers | View raw

On Friday, October 09, 2015 4:27 AM, Ian Abbott wrote:
> A few changes for the "poll" file operation to avoid poll-waiting on the
> same subdevice for both read and write (patch 1), avoid allocating write
> buffer space unnecessarily and possibly inappropriately (patch 4),
> consider whether any active commands belong to the current file object
> (patch 5), and avoid using the main mutex (for performance reasons)
> (patch 6).
>
> 1) staging: comedi: don't poll_wait on same subdevice twice
> 2) staging: comedi: rename comedi_buf_write_n_available
> 3) staging: comedi: add new comedi_buf_write_n_available()
> 4) staging: comedi: don't allocate buffer space when polling for write
> 5) staging: comedi: check command started by file being polled
> 6) staging: comedi: don't use mutex when polling file
>
>  drivers/staging/comedi/comedi_buf.c      | 19 +++++++++++++------
>  drivers/staging/comedi/comedi_fops.c     | 17 +++++++++--------
>  drivers/staging/comedi/comedi_internal.h |  1 +
>  3 files changed, 23 insertions(+), 14 deletions(-)

Thanks!

Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/6] staging: comedi: fix some minor issues with file poll op Ian Abbott <abbotti@mev.co.uk> - 2015-10-09 13:30 +0200
  [PATCH 5/6] staging: comedi: check command started by file being polled Ian Abbott <abbotti@mev.co.uk> - 2015-10-09 13:30 +0200
  [PATCH 6/6] staging: comedi: don't use mutex when polling file Ian Abbott <abbotti@mev.co.uk> - 2015-10-09 13:30 +0200
    RE: [PATCH 6/6] staging: comedi: don't use mutex when polling file Hartley Sweeten <HartleyS@visionengravers.com> - 2015-10-09 19:30 +0200
  [PATCH 1/6] staging: comedi: don't poll_wait on same subdevice twice Ian Abbott <abbotti@mev.co.uk> - 2015-10-09 13:30 +0200
  RE: [PATCH 0/6] staging: comedi: fix some minor issues with file poll  op Hartley Sweeten <HartleyS@visionengravers.com> - 2015-10-09 19:30 +0200

csiph-web