Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1243510

Re: [PATCH v2 1/2] devicetree: add binding for generic mmio clocksource

Show all headers | View raw

Måns Rullgård <mans@mansr.com> writes:

> Rob Herring <robherring2@gmail.com> writes:
>
>> On Wed, Oct 7, 2015 at 11:47 AM, Måns Rullgård <mans@mansr.com> wrote:
>>> What would be a proper way to select a sched_clock source?  I realise
>>> it's a Linux-specific thing and DT is supposed to be generic, but the
>>> information must be provided somehow.
>>
>> The kernel already has some logic to do this. Most number of bits
>> followed by highest frequency will be the winning sched_clock. You
>> might also want to look at things like always on or not.
>
> The problem is that sched_clock_register() doesn't take a pointer to be
> passed back to the read_sched_clock callback like most interfaces of
> this type do.  This means the callback must use global variables set up
> before the register call, but at that time there's no way of knowing
> which one will be used.  If there were a way of getting a pointer to the
> callback, it would be a simple matter of registering all instances and
> letting the kernel choose which to use.

Anyone got a comment on this?  Do I have to send a patch adding this
before anyone will tell me why it's a bad idea?  (That method almost
always works.)

-- 
Måns Rullgård
mans@mansr.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 1/2] devicetree: add binding for generic mmio clocksource Mans Rullgard <mans@mansr.com> - 2015-10-07 17:40 +0200
  [PATCH v2 2/2] clocksource: mmio: add devicetree support Mans Rullgard <mans@mansr.com> - 2015-10-07 17:40 +0200
  Re: [PATCH v2 1/2] devicetree: add binding for generic mmio  clocksource Mark Rutland <mark.rutland@arm.com> - 2015-10-07 17:50 +0200
    Re: [PATCH v2 1/2] devicetree: add binding for generic mmio clocksource Måns Rullgård <mans@mansr.com> - 2015-10-07 18:50 +0200
      Re: [PATCH v2 1/2] devicetree: add binding for generic mmio  clocksource Mark Rutland <mark.rutland@arm.com> - 2015-10-07 19:10 +0200
        Re: [PATCH v2 1/2] devicetree: add binding for generic mmio clocksource Måns Rullgård <mans@mansr.com> - 2015-10-08 11:20 +0200
      Re: [PATCH v2 1/2] devicetree: add binding for generic mmio clocksource Rob Herring <robherring2@gmail.com> - 2015-10-07 21:50 +0200
        Re: [PATCH v2 1/2] devicetree: add binding for generic mmio clocksource Måns Rullgård <mans@mansr.com> - 2015-10-08 11:30 +0200
          Re: [PATCH v2 1/2] devicetree: add binding for generic mmio clocksource Måns Rullgård <mans@mansr.com> - 2015-10-09 18:20 +0200
            Re: [PATCH v2 1/2] devicetree: add binding for generic mmio clocksource Rob Herring <robherring2@gmail.com> - 2015-10-09 20:00 +0200
              Re: [PATCH v2 1/2] devicetree: add binding for generic mmio  clocksource Stephen Boyd <sboyd@codeaurora.org> - 2015-10-09 20:50 +0200
                Re: [PATCH v2 1/2] devicetree: add binding for generic mmio clocksource Måns Rullgård <mans@mansr.com> - 2015-10-09 21:50 +0200
                Re: [PATCH v2 1/2] devicetree: add binding for generic mmio  clocksource Stephen Boyd <sboyd@codeaurora.org> - 2015-10-10 02:10 +0200
                Re: [PATCH v2 1/2] devicetree: add binding for generic mmio clocksource Måns Rullgård <mans@mansr.com> - 2015-10-10 00:00 +0200
                Re: [PATCH v2 1/2] devicetree: add binding for generic mmio  clocksource Stephen Boyd <sboyd@codeaurora.org> - 2015-10-10 02:10 +0200

csiph-web