Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1243396

Re: [PATCH 1/1] x86/intel-mid: modify a code to suppress a warning

From Thomas Gleixner <tglx@linutronix.de>
Newsgroups linux.kernel
Subject Re: [PATCH 1/1] x86/intel-mid: modify a code to suppress a warning
Date 2015-10-09 16:10 +0200
Message-ID <qhGwV-4li-1@gated-at.bofh.it> (permalink)
References <qhG3T-3xZ-17@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Fri, 9 Oct 2015, Andy Shevchenko wrote:

Please stop to write subject lines like this.

     x86/intel-mid: modify a code to suppress a warning

This is completely useless as it does not tell what kind of warning
(compile time, runtime). Further it says that the patch modifies
code, which is completely pointless, right?

What's wrong with:

     x86/intel-mid: Make intel_mid_ops static

I end up rewriting your subject lines and changelogs on a regular
base. You really should have noticed that by now and started to spend
a little bit more effort yourself.

Thanks,

	tglx


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 1/1] x86/intel-mid: modify a code to suppress a warning Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2015-10-09 15:40 +0200
  Re: [PATCH 1/1] x86/intel-mid: modify a code to suppress a warning Thomas Gleixner <tglx@linutronix.de> - 2015-10-09 16:10 +0200
    Re: [PATCH 1/1] x86/intel-mid: modify a code to suppress a warning Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2015-10-09 17:20 +0200

csiph-web