Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1243228
| From | Paolo Bonzini <pbonzini@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] kvm: fix waitqueue_active without memory barrier in virt/kvm/async_pf.c |
| Date | 2015-10-09 12:30 +0200 |
| Message-ID | <qhD62-7Lm-19@gated-at.bofh.it> (permalink) |
| References | <qhtT7-2Qh-83@gated-at.bofh.it> <qhBxg-5rH-23@gated-at.bofh.it> <qhBGX-5Da-35@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 09/10/2015 10:50, Peter Zijlstra wrote:
> Not having actually read or thought about the issue at hand, its
> perfectly valid to pair an smp_mb() with either spin_lock() or
> spin_unlock().
>
> IOW. MB <-> {ACQUIRE, RELEASE} is a valid pairing.
In this case it's an smp_mb() (store-load barrier) being paired with
another smp_mb(), so spin_unlock()'s release is not enough.
Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] kvm: fix waitqueue_active without memory barrier in virt/kvm/async_pf.c Kosuke Tatsukawa <tatsu@ab.jp.nec.com> - 2015-10-09 02:40 +0200
Re: [PATCH] kvm: fix waitqueue_active without memory barrier in virt/kvm/async_pf.c Paolo Bonzini <pbonzini@redhat.com> - 2015-10-09 10:50 +0200
Re: [PATCH] kvm: fix waitqueue_active without memory barrier in virt/kvm/async_pf.c Peter Zijlstra <peterz@infradead.org> - 2015-10-09 11:00 +0200
Re: [PATCH] kvm: fix waitqueue_active without memory barrier in virt/kvm/async_pf.c Paolo Bonzini <pbonzini@redhat.com> - 2015-10-09 12:30 +0200
Re: [PATCH] kvm: fix waitqueue_active without memory barrier in virt/kvm/async_pf.c Kosuke Tatsukawa <tatsu@ab.jp.nec.com> - 2015-10-09 11:10 +0200
Re: [PATCH] kvm: fix waitqueue_active without memory barrier in virt/kvm/async_pf.c Paolo Bonzini <pbonzini@redhat.com> - 2015-10-09 12:30 +0200
Re: [PATCH] kvm: fix waitqueue_active without memory barrier in virt/kvm/async_pf.c Kosuke Tatsukawa <tatsu@ab.jp.nec.com> - 2015-10-09 14:30 +0200
csiph-web