Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1243223

Re: [RFC]: Possible race condition in kernel futex code

Show all headers | View raw

Hans,

On Fri, 9 Oct 2015, Hans Zuidam wrote:
> On 9 okt. 2015, at 11:06, Thomas Gleixner <tglx@linutronix.de> wrote:
> > You cannot use an explicit 32bit read. We need an access which
> > handles the fault gracefully.
>
> The reason for the explicit read suggestion is to avoid the
> _builtin_constant_p() in __copy_from_user_nocheck().  The GCC manual
> says that there may be situations where it returns 0 even though the
> argument is a constant.

That's insane at best.

> Although none of the compiler/kernel combinations we have tried
> showed this happening, we think it is probably better to be safe
> than sorry.

So we would need something like:

   futex_copy_from_user()

which can be mapped to __copy_from_user_inatomic() first. Then go
through all architectures and the asm-generic stuff and provide the
specific variants which are guaranteed to use a 32bit access.

I really prefer that we don't have to do that and the compiler people
get their act together and fix that _builtin_constant_p() thingy.

Thanks,

	tglx

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [RFC]: Possible race condition in kernel futex code Thomas Gleixner <tglx@linutronix.de> - 2015-10-09 11:10 +0200
  Re: [RFC]: Possible race condition in kernel futex code Hans Zuidam <h.zuidam@online.nl> - 2015-10-09 12:00 +0200
    Re: [RFC]: Possible race condition in kernel futex code Thomas Gleixner <tglx@linutronix.de> - 2015-10-09 12:30 +0200
      Re: [RFC]: Possible race condition in kernel futex code Peter Zijlstra <peterz@infradead.org> - 2015-10-09 13:40 +0200
  Re: [RFC]: Possible race condition in kernel futex code Greg KH <greg@kroah.com> - 2015-10-18 02:30 +0200

csiph-web