Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1243218

Re: [PATCH v2 3/5] ARM: mvebu: set SW polling as SDHCI card detection on A388-GP

Show all headers | View raw

Hi Thomas,


2015-10-09 9:52 GMT+02:00 Thomas Petazzoni
<thomas.petazzoni@free-electrons.com>:
> Dear Marcin Wojtas,
>
> On Fri,  9 Oct 2015 03:03:53 +0200, Marcin Wojtas wrote:
>> The newest revisions of A388-GP (v1.5 and higher) support only
>> DAT3-based card detection. Revisions < v1.5 based on GPIO detection
>> via I2C expander, but this solution is supposed to be deprecated on
>> new boards. In order to satisfy all type of hardware this commit
>> changes card detection to use software polling mechanism.
>>
>> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
>
> Can we add a comment on the DT that explains why SW polling is used,
> and which other mechanism can be used depending on the board revision?

Sure, good idea. Do you think the below would be sufficient?
sdhci@d8000 {
    pinctrl-names = "default";
    pinctrl-0 = <&sdhci_pins>;
    no-1-8-v;
    /*
     * A388-GP board v1.5 and higher replace
     * hitherto card detection method based on GPIO
     * with the one using DAT3 pin. As they are
     * incompatible, software-based polling is
     * enabled with 'broken-cd' property. For boards
     * older than v1.5 it can be replaced with:
     * 'cd-gpios = <&expander0 5 GPIO_ACTIVE_LOW>;',
     * whereas for the newer ones following can be
     * used instead:
     * 'dat3-cd;'
     * 'cd-inverted;'
     */
broken-cd;
wp-inverted;
bus-width = <8>;
status = "okay";
};

Best regards,
Marcin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 3/5] ARM: mvebu: set SW polling as SDHCI card detection on A388-GP Marcin Wojtas <mw@semihalf.com> - 2015-10-09 03:00 +0200
  Re: [PATCH v2 3/5] ARM: mvebu: set SW polling as SDHCI card  detection on A388-GP Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2015-10-09 10:00 +0200
    Re: [PATCH v2 3/5] ARM: mvebu: set SW polling as SDHCI card detection  on A388-GP Marcin Wojtas <mw@semihalf.com> - 2015-10-09 12:20 +0200
  Re: [PATCH v2 3/5] ARM: mvebu: set SW polling as SDHCI card  detection on A388-GP Andrew Lunn <andrew@lunn.ch> - 2015-10-09 15:50 +0200

csiph-web