Re: [PATCH 4/4] arm64: dts: enable idle states for Hi6220

From	Leo Yan <leo.yan@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4/4] arm64: dts: enable idle states for Hi6220
Date	2015-10-09 11:00 +0200
Message-ID	<qhBGW-5Da-21@gated-at.bofh.it> (permalink)
References	<qhxDk-8kk-5@gated-at.bofh.it> <qhxDk-8kk-13@gated-at.bofh.it> <qhBxh-5rH-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Sudeep,

On Fri, Oct 09, 2015 at 09:48:17AM +0100, Sudeep Holla wrote:
> 
> 
> On 09/10/15 05:36, Leo Yan wrote:
> >Add cpu and cluster level's low power state for Hi6220.
> >
> >Signed-off-by: Leo Yan <leo.yan@linaro.org>
> >---
> >  arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 31 +++++++++++++++++++++++++++++++
> >  1 file changed, 31 insertions(+)
> >
> >diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> >index 7edbe42..e83802a 100644
> >--- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> >+++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> >@@ -52,11 +52,35 @@
> >  			};
> >  		};
> >
> >+		idle-states {
> >+			entry-method = "arm,psci";
> 
> Please refer the bindings:           ^ should be just "psci"
> 
> Otherwise looks good.
> Acked-by: Sudeep Holla <sudeep.holla@arm.com>

Will fix it, thanks for review.

Thanks,
Leo Yan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH 0/4] arm64: Hi6220: enable CPU idle states Leo Yan <leo.yan@linaro.org> - 2015-10-09 06:40 +0200
  [PATCH 1/4] arm64: dts: Reserve memory regions for hi6220 Leo Yan <leo.yan@linaro.org> - 2015-10-09 06:40 +0200
    Re: [PATCH 1/4] arm64: dts: Reserve memory regions for hi6220 Rob Herring <robherring2@gmail.com> - 2015-10-09 15:20 +0200
      Re: [PATCH 1/4] arm64: dts: Reserve memory regions for hi6220 Mark Rutland <mark.rutland@arm.com> - 2015-10-09 15:40 +0200
        Re: [PATCH 1/4] arm64: dts: Reserve memory regions for hi6220 Rob Herring <robherring2@gmail.com> - 2015-10-09 16:00 +0200
          Re: [PATCH 1/4] arm64: dts: Reserve memory regions for hi6220 Leo Yan <leo.yan@linaro.org> - 2015-10-09 16:30 +0200
  [PATCH 4/4] arm64: dts: enable idle states for Hi6220 Leo Yan <leo.yan@linaro.org> - 2015-10-09 06:40 +0200
    Re: [PATCH 4/4] arm64: dts: enable idle states for Hi6220 Sudeep Holla <sudeep.holla@arm.com> - 2015-10-09 10:50 +0200
      Re: [PATCH 4/4] arm64: dts: enable idle states for Hi6220 Leo Yan <leo.yan@linaro.org> - 2015-10-09 11:00 +0200
  [PATCH 3/4] arm64: dts: add sp804 timer node for Hi6220 Leo Yan <leo.yan@linaro.org> - 2015-10-09 06:40 +0200
    Re: [PATCH 3/4] arm64: dts: add sp804 timer node for Hi6220 Rob Herring <robherring2@gmail.com> - 2015-10-09 15:20 +0200
  [PATCH 2/4] arm64: Kconfig: select sp804 timer for ARCH_HISI Leo Yan <leo.yan@linaro.org> - 2015-10-09 06:40 +0200

csiph-web