Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1241902

[PATCH 01/10] Drivers: hv: util: Increase the timeout for util services

From "K. Y. Srinivasan" <kys@microsoft.com>
Newsgroups linux.kernel
Subject [PATCH 01/10] Drivers: hv: util: Increase the timeout for util services
Date 2015-10-08 02:40 +0200
Message-ID <qh7pv-4eQ-9@gated-at.bofh.it> (permalink)
References <qh7pv-4eQ-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Util services such as KVP and FCOPY need assistance from daemon's running
in user space. Increase the timeout so we don't prematurely terminate
the transaction in the kernel.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
---
 drivers/hv/hv_fcopy.c     |    3 ++-
 drivers/hv/hv_kvp.c       |    3 ++-
 drivers/hv/hyperv_vmbus.h |    5 +++++
 3 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/drivers/hv/hv_fcopy.c b/drivers/hv/hv_fcopy.c
index db4b887..bbdec50 100644
--- a/drivers/hv/hv_fcopy.c
+++ b/drivers/hv/hv_fcopy.c
@@ -275,7 +275,8 @@ void hv_fcopy_onchannelcallback(void *context)
 		 * Send the information to the user-level daemon.
 		 */
 		schedule_work(&fcopy_send_work);
-		schedule_delayed_work(&fcopy_timeout_work, 5*HZ);
+		schedule_delayed_work(&fcopy_timeout_work,
+				      HV_UTIL_TIMEOUT * HZ);
 		return;
 	}
 	icmsghdr->icflags = ICMSGHDRFLAG_TRANSACTION | ICMSGHDRFLAG_RESPONSE;
diff --git a/drivers/hv/hv_kvp.c b/drivers/hv/hv_kvp.c
index 74c38a9..e6aa33a 100644
--- a/drivers/hv/hv_kvp.c
+++ b/drivers/hv/hv_kvp.c
@@ -668,7 +668,8 @@ void hv_kvp_onchannelcallback(void *context)
 			 * user-mode not responding.
 			 */
 			schedule_work(&kvp_sendkey_work);
-			schedule_delayed_work(&kvp_timeout_work, 5*HZ);
+			schedule_delayed_work(&kvp_timeout_work,
+					      HV_UTIL_TIMEOUT * HZ);
 
 			return;
 
diff --git a/drivers/hv/hyperv_vmbus.h b/drivers/hv/hyperv_vmbus.h
index 3d70e36..f26599b 100644
--- a/drivers/hv/hyperv_vmbus.h
+++ b/drivers/hv/hyperv_vmbus.h
@@ -31,6 +31,11 @@
 #include <linux/hyperv.h>
 
 /*
+ * Timeout for services such as KVP and fcopy.
+ */
+#define HV_UTIL_TIMEOUT 30
+
+/*
  * The below CPUID leaves are present if VersionAndFeatures.HypervisorPresent
  * is set by CPUID(HVCPUID_VERSION_FEATURES).
  */
-- 
1.7.4.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 00/10] Drivers: hv: Miscellaneous fixes.   "K. Y. Srinivasan" <kys@microsoft.com> - 2015-10-08 02:40 +0200
  [PATCH 07/10] drivers/hv: cleanup synic msrs if vmbus connect failed "K. Y. Srinivasan" <kys@microsoft.com> - 2015-10-08 02:40 +0200
    Re: [PATCH 07/10] drivers/hv: cleanup synic msrs if vmbus connect  failed "Denis V. Lunev" <den@openvz.org> - 2015-10-08 19:30 +0200
      RE: [PATCH 07/10] drivers/hv: cleanup synic msrs if vmbus connect  failed KY Srinivasan <kys@microsoft.com> - 2015-10-08 19:30 +0200
        Re: [PATCH 07/10] drivers/hv: cleanup synic msrs if vmbus connect  failed "Denis V. Lunev" <den@openvz.org> - 2015-10-08 19:40 +0200
  [PATCH 01/10] Drivers: hv: util: Increase the timeout for util services "K. Y. Srinivasan" <kys@microsoft.com> - 2015-10-08 02:40 +0200
    Re: [PATCH 01/10] Drivers: hv: util: Increase the timeout for util  services Olaf Hering <olaf@aepfle.de> - 2015-10-08 15:30 +0200
      RE: [PATCH 01/10] Drivers: hv: util: Increase the timeout for util  services KY Srinivasan <kys@microsoft.com> - 2015-10-08 16:50 +0200

csiph-web