[PATCH 1/3] perf tools: Get rid of superfluos call to reset_dimensions

From	Jiri Olsa <jolsa@kernel.org>
Newsgroups	linux.kernel
Subject	[PATCH 1/3] perf tools: Get rid of superfluos call to reset_dimensions
Date	2015-10-06 14:30 +0200
Message-ID	<qgzxw-63y-7@gated-at.bofh.it> (permalink)
References	<qgzxw-63y-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

There's no need to call reset_dimensions within __setup_output_field
function. It's already called in its caller setup_sorting right
before perf_hpp__init, which will be changed in following patch
to respect taken dimension.

Link: http://lkml.kernel.org/n/tip-08mxvkxtuxbboog1exjok9gd@git.kernel.org
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
---
 tools/perf/util/sort.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c
index ee94b728fca4..8521e3c89b8d 100644
--- a/tools/perf/util/sort.c
+++ b/tools/perf/util/sort.c
@@ -1917,8 +1917,6 @@ static int __setup_output_field(void)
 	if (field_order == NULL)
 		return 0;
 
-	reset_dimensions();
-
 	strp = str = strdup(field_order);
 	if (str == NULL) {
 		error("Not enough memory to setup output fields");
-- 
2.4.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/3] perf tools: Get rid of superfluos call to reset_dimensions Jiri Olsa <jolsa@kernel.org> - 2015-10-06 14:30 +0200
  [tip:perf/core] perf tools:   Get rid of superfluos call to reset_dimensions tip-bot for Jiri Olsa <tipbot@zytor.com> - 2015-10-08 11:50 +0200

csiph-web