Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1240156

Re: [PATCH v2 1/3] Input: db9 - store object at correct index

Show all headers | View raw

On Mon, Oct 05, 2015 at 05:32:05PM -0700, Dmitry Torokhov wrote:
> On Sat, Oct 03, 2015 at 02:54:56PM +0530, Sudip Mukherjee wrote:
> > The variable i is used to check the port to attach to and we are
> > supposed to save the reference of struct db9 in the location given by
> > db9_base[i]. But after finding out the index, i is getting modified again
> > so we saved in a wrong index.
> > While at it mark db9_base[i] as NULL after it is freed.
> > 
> > Fixes: 2260c419b52b ("Input: db9 - use parallel port device model")
> > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> 
> Applied the lot, thank you.

Thanks. And the change for serio/parkbd was pending. You said it was
clashing with other changs.  Do i need to rebase and send you?

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 1/3] Input: db9 - store object at correct index Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-10-03 11:30 +0200
  Re: [PATCH v2 1/3] Input: db9 - store object at correct index Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2015-10-06 02:40 +0200
    Re: [PATCH v2 1/3] Input: db9 - store object at correct index Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-10-06 07:40 +0200
      Re: [PATCH v2 1/3] Input: db9 - store object at correct index Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2015-10-07 00:40 +0200

csiph-web