Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1240154

[PATCHv2] ARM64:Fix MINSIGSTKSZ and SIGSTKSZ

From Manjeet Pawar <manjeet.p@samsung.com>
Newsgroups linux.kernel
Subject [PATCHv2] ARM64:Fix MINSIGSTKSZ and SIGSTKSZ
Date 2015-10-06 07:40 +0200
Message-ID <qgt8K-5bf-5@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw


MINSIGSTKSZ and SIGSTKSZ for ARM64 are not correctly set in latest kernel.
This patch fixes this issue.

This issue is reported in LTP (testcase: sigaltstack02.c).
Testcase failed when sigaltstack() called with stack size "MINSIGSTKSZ - 1"
Since in Glibc-2.22, MINSIGSTKSZ is set to 5120 but in kernel
it is set to 2048 so testcase gets failed.

Testcase Output:
sigaltstack02 1  TPASS  :  stgaltstack() fails, Invalid Flag value,errno:22
sigaltstack02 2  TFAIL  :  sigaltstack() returned 0, expected -1,errno:12

Reported Issue in Glibc Bugzilla:
https://sourceware.org/bugzilla/show_bug.cgi?id=16850

Bugfix in Glibc-2.22:
https://sourceware.org/git/gitweb.cgi?p=glibc.git;a=blob;f=sysdeps/unix/
sysv/linux/aarch64/bits/sigstack.h;h=8f2fb76e3e81734ef8a9cf9ae40daf4705
f31c35;hb=b763f6ae859ecea70a5dacb8ad45c71d5f667e2e

Signed-off-by: Akhilesh Kumar <akhilesh.k@samsung.com>
Signed-off-by: Manjeet Pawar <manjeet.p@samsung.com>
Signed-off-by: Rohit Thapliyal <r.thapliyal@samsung.com>

---
v1 -> Changes in uapi overall header
v2 -> Changes done in arm64 headers

 arch/arm64/include/uapi/asm/signal.h |    5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm64/include/uapi/asm/signal.h b/arch/arm64/include/uapi/asm/signal.h
index 8d1e723..5ac56cf 100644
--- a/arch/arm64/include/uapi/asm/signal.h
+++ b/arch/arm64/include/uapi/asm/signal.h
@@ -21,4 +21,9 @@
 
 #include <asm-generic/signal.h>
 
+#undef MINSIGSTKSZ
+#undef SIGSTKSZ
+#define MINSIGSTKSZ 5120
+#define SIGSTKSZ    16384
+
 #endif
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

[PATCHv2] ARM64:Fix MINSIGSTKSZ and SIGSTKSZ Manjeet Pawar <manjeet.p@samsung.com> - 2015-10-06 07:40 +0200
  Re: [PATCHv2] ARM64:Fix MINSIGSTKSZ and SIGSTKSZ Arnd Bergmann <arnd@arndb.de> - 2015-10-06 09:50 +0200
    Re: [PATCHv2] ARM64:Fix MINSIGSTKSZ and SIGSTKSZ Catalin Marinas <catalin.marinas@arm.com> - 2015-10-06 11:40 +0200
    Re: [PATCHv2] ARM64:Fix MINSIGSTKSZ and SIGSTKSZ Dave Martin <Dave.Martin@arm.com> - 2015-10-06 12:40 +0200
      Re: [PATCHv2] ARM64:Fix MINSIGSTKSZ and SIGSTKSZ Andreas Schwab <schwab@suse.de> - 2015-10-06 13:00 +0200
        Re: [PATCHv2] ARM64:Fix MINSIGSTKSZ and SIGSTKSZ Dave Martin <Dave.Martin@arm.com> - 2015-10-06 13:40 +0200
          Re: [PATCHv2] ARM64:Fix MINSIGSTKSZ and SIGSTKSZ Andreas Schwab <schwab@suse.de> - 2015-10-06 14:00 +0200
            Re: [PATCHv2] ARM64:Fix MINSIGSTKSZ and SIGSTKSZ Dave Martin <Dave.Martin@arm.com> - 2015-10-06 14:50 +0200
      Re: [PATCHv2] ARM64:Fix MINSIGSTKSZ and SIGSTKSZ Arnd Bergmann <arnd@arndb.de> - 2015-10-06 13:00 +0200
        Re: [PATCHv2] ARM64:Fix MINSIGSTKSZ and SIGSTKSZ Dave Martin <Dave.Martin@arm.com> - 2015-10-06 13:30 +0200
        Re: [PATCHv2] ARM64:Fix MINSIGSTKSZ and SIGSTKSZ Arnd Bergmann <arnd@arndb.de> - 2015-10-09 10:50 +0200
          Re: [PATCHv2] ARM64:Fix MINSIGSTKSZ and SIGSTKSZ Dave Martin <Dave.Martin@arm.com> - 2015-10-12 16:00 +0200
  Re: [PATCHv2] ARM64:Fix MINSIGSTKSZ and SIGSTKSZ Will Deacon <will.deacon@arm.com> - 2015-10-06 12:30 +0200

csiph-web