Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1239755

[PATCH] serial: atmel: fix compiler warning on address cast

Show all headers | View raw

Turning on KVM and LPAE support on top of a multi_v7_defconfig will
produce a compiler warning in the Atmel serial driver:
drivers/tty/serial/atmel_serial.c: In function 'atmel_verify_port':
drivers/tty/serial/atmel_serial.c:2299:6: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
  if ((void *)port->mapbase != ser->iomem_base)
      ^

Fix that by using the cast on the right hand side instead, as similar
code already does in other drivers.

Signed-off-by: Andre Przywara <andre.przywara@arm.com>
---
 drivers/tty/serial/atmel_serial.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c
index cd30a45..28039ce 100644
--- a/drivers/tty/serial/atmel_serial.c
+++ b/drivers/tty/serial/atmel_serial.c
@@ -2296,7 +2296,7 @@ static int atmel_verify_port(struct uart_port *port, struct serial_struct *ser)
 		ret = -EINVAL;
 	if (port->uartclk / 16 != ser->baud_base)
 		ret = -EINVAL;
-	if ((void *)port->mapbase != ser->iomem_base)
+	if (port->mapbase != (unsigned long)ser->iomem_base)
 		ret = -EINVAL;
 	if (port->iobase != ser->port)
 		ret = -EINVAL;
-- 
2.5.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] serial: atmel: fix compiler warning on address cast Andre Przywara <andre.przywara@arm.com> - 2015-10-05 19:10 +0200
  Re: [PATCH] serial: atmel: fix compiler warning on address cast Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2015-10-08 11:10 +0200
    Re: [PATCH] serial: atmel: fix compiler warning on address cast Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-10-08 11:40 +0200
      Re: [PATCH] serial: atmel: fix compiler warning on address cast Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2015-10-08 12:40 +0200
        Re: [PATCH] serial: atmel: fix compiler warning on address cast Andre Przywara <andre.przywara@arm.com> - 2015-10-08 17:00 +0200
          Re: [PATCH] serial: atmel: fix compiler warning on address cast Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-10-08 17:10 +0200

csiph-web