Re: [PATCH] mm/mmap.c: Remove redundant statement "error = -ENOMEM"

From	Oleg Nesterov <oleg@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mm/mmap.c: Remove redundant statement "error = -ENOMEM"
Date	2015-10-05 18:30 +0200
Message-ID	<qggOe-4bm-21@gated-at.bofh.it> (permalink)
References	<qggld-3nE-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 10/05, Chen Gang wrote:
>
> It is still a little better to remove it, although it should be skipped
> by "-O2".

Agreed, it can confuse the reader.

> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>

Acked-by: Oleg Nesterov <oleg@redhat.com>

> ---
>  mm/mmap.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/mm/mmap.c b/mm/mmap.c
> index 8393580..1da4600 100644
> --- a/mm/mmap.c
> +++ b/mm/mmap.c
> @@ -1562,7 +1562,6 @@ unsigned long mmap_region(struct file *file, unsigned long addr,
>  	}
>  
>  	/* Clear old maps */
> -	error = -ENOMEM;
>  	while (find_vma_links(mm, addr, addr + len, &prev, &rb_link,
>  			      &rb_parent)) {
>  		if (do_munmap(mm, addr, len))
> -- 
> 1.9.3
> 
>  		 	   		  


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] mm/mmap.c: Remove redundant statement "error = -ENOMEM" Chen Gang <xili_gchen_5257@hotmail.com> - 2015-10-05 18:00 +0200
  Re: [PATCH] mm/mmap.c: Remove redundant statement "error = -ENOMEM" Oleg Nesterov <oleg@redhat.com> - 2015-10-05 18:30 +0200

csiph-web