Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1239663

Re: [PATCH][RESEND] drm: panel-simple: add URT UMSH-8596MD-xT panel support

Show all headers | View raw

Hi Thierry,

On 05.10.2015 13:01, Thierry Reding wrote:
>> On 01.09.2015 15:50, Maciej S. Szmigiero wrote:
>>> This patch adds support for United Radiant Technology
>>> UMSH-8596MD-xT 7.0" WVGA TFT LCD panels
>>> (both LVDS and parallel versions) to DRM
>>> panel-simple driver.
>>>
>>> Signed-off-by: Maciej Szmigiero <mail@maciej.szmigiero.name>
>>> ---
>>> This is a resend without changes.
>>>
>>> diff --git a/Documentation/devicetree/bindings/panel/urt,umsh-8596md.txt b/Documentation/devicetree/bindings/panel/urt,umsh-8596md.txt
>>> new file mode 100644
>>> index 0000000..2990e6b
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/panel/urt,umsh-8596md.txt
>>> @@ -0,0 +1,11 @@
>>> +United Radiant Technology UMSH-8596MD-xT 7.0" WVGA TFT LCD panel
>>> +
>>> +Supported are LVDS versions (-11T, -19T) and parallel ones
>>> +(-T, -1T, -7T, -20T).
> 
> Please don't use this kind of wildcard compatible values. If these are
> different models then each of them deserves a separate compatible
> string.

The differences between these revisions are like different maximum backlight
luminance or presence / absence of touch panel.

None of this changes panel timings - should they be split into different
compatible values anyway?

>>> You might want to
>>> split the DT binding and vendor prefix to separate patches.
>>
>> Do you mean to first submit new vendor prefix then panel patch with docs?
>> Or even docs separately?
> 
> This should be three patches: the vendor prefix is usually a separate
> patch and needs an Acked-by from one of the device tree bindings
> maintainers. The binding itself should also be a separate patch and the
> driver changes should come last.

I will split the patch and first submit DT binding docs.

> Thierry

Best regards,
Maciej

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH][RESEND] drm: panel-simple: add URT UMSH-8596MD-xT panel  support "Maciej S. Szmigiero" <mail@maciej.szmigiero.name> - 2015-10-02 23:50 +0200
  Re: [PATCH][RESEND] drm: panel-simple: add URT UMSH-8596MD-xT panel support Emil Velikov <emil.l.velikov@gmail.com> - 2015-10-04 12:50 +0200
    Re: [PATCH][RESEND] drm: panel-simple: add URT UMSH-8596MD-xT panel  support "Maciej S. Szmigiero" <mail@maciej.szmigiero.name> - 2015-10-05 01:40 +0200
      Re: [PATCH][RESEND] drm: panel-simple: add URT UMSH-8596MD-xT panel  support Thierry Reding <thierry.reding@gmail.com> - 2015-10-05 13:00 +0200
  Re: [PATCH][RESEND] drm: panel-simple: add URT UMSH-8596MD-xT panel  support Thierry Reding <thierry.reding@gmail.com> - 2015-10-05 13:10 +0200
    Re: [PATCH][RESEND] drm: panel-simple: add URT UMSH-8596MD-xT panel  support "Maciej S. Szmigiero" <mail@maciej.szmigiero.name> - 2015-10-05 17:30 +0200
      Re: [PATCH][RESEND] drm: panel-simple: add URT UMSH-8596MD-xT panel  support Thierry Reding <thierry.reding@gmail.com> - 2015-10-06 11:20 +0200

csiph-web