[PATCH 5/5] Drivers: hv: utils: use memdup_user in hvt_op_write

From	Olaf Hering <olaf@aepfle.de>
Newsgroups	linux.kernel
Subject	[PATCH 5/5] Drivers: hv: utils: use memdup_user in hvt_op_write
Date	2015-10-05 17:30 +0200
Message-ID	<qgfS9-2Pr-5@gated-at.bofh.it> (permalink)
References	<qgfS9-2Pr-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Use memdup_user to handle OOM.

Fixes: 14b50f80c32d ('Drivers: hv: util: introduce hv_utils_transport abstraction')

Signed-off-by: Olaf Hering <olaf@aepfle.de>
---
 drivers/hv/hv_utils_transport.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/hv/hv_utils_transport.c b/drivers/hv/hv_utils_transport.c
index 1505ee6..24b2766 100644
--- a/drivers/hv/hv_utils_transport.c
+++ b/drivers/hv/hv_utils_transport.c
@@ -80,11 +80,10 @@ static ssize_t hvt_op_write(struct file *file, const char __user *buf,
 
 	hvt = container_of(file->f_op, struct hvutil_transport, fops);
 
-	inmsg = kzalloc(count, GFP_KERNEL);
-	if (copy_from_user(inmsg, buf, count)) {
-		kfree(inmsg);
-		return -EFAULT;
-	}
+	inmsg = memdup_user(buf, count);
+	if (IS_ERR(inmsg))
+		return PTR_ERR(inmsg);
+
 	if (hvt->on_msg(inmsg, count))
 		return -EFAULT;
 	kfree(inmsg);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH 5/5] Drivers: hv: utils: use memdup_user in hvt_op_write Olaf Hering <olaf@aepfle.de> - 2015-10-05 17:30 +0200

csiph-web