Re: [PATCH 1/3] BTRFS: support NFSv2 export

From	Chris Mason <clm@fb.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/3] BTRFS: support NFSv2 export
Date	2015-10-05 16:40 +0200
Message-ID	<qgf5M-1ED-21@gated-at.bofh.it> (permalink)
References	<pnENY-2pn-1@gated-at.bofh.it> <pnENY-2pn-3@gated-at.bofh.it> <poR6p-3a3-7@gated-at.bofh.it> <qc48V-5Uv-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Sep 24, 2015 at 11:59:02AM +1000, Neil Brown wrote:
> David Sterba <dsterba@suse.cz> writes:
> 
> > On Fri, May 08, 2015 at 10:16:23AM +1000, NeilBrown wrote:
> >> The "fh_len" passed to ->fh_to_* is not guaranteed to be that same as
> >> that returned by encode_fh - it may be larger.
> >> 
> >> With NFSv2, the filehandle is fixed length, so it may appear longer
> >> than expected and be zero-padded.
> >> 
> >> So we must test that fh_len is at least some value, not exactly equal
> >> to it.
> >> 
> >> Signed-off-by: NeilBrown <neilb@suse.de>
> >
> > Acked-by: David Sterba <dsterba@suse.cz>
> 
> Thanks.  However I just checked mainline and this still hasn't been
> applied.
> Should I resend it to someone?  Who?


Sorry Neil, I thought you were pushing these after it was ack'd.  I'll
put it in my pull this week.

-chris

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/3] BTRFS: support NFSv2 export Neil Brown <neilb@suse.de> - 2015-09-24 04:10 +0200
  Re: [PATCH 1/3] BTRFS: support NFSv2 export Chris Mason <clm@fb.com> - 2015-10-05 16:40 +0200

csiph-web