Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1239579

Re: [PATCH] ovs: do not allocate memory from offline numa node

Show all headers | View raw

On 10/02/2015 12:18 PM, Konstantin Khlebnikov wrote:
> When openvswitch tries allocate memory from offline numa node 0:
> stats = kmem_cache_alloc_node(flow_stats_cache, GFP_KERNEL | __GFP_ZERO, 0)
> It catches VM_BUG_ON(nid < 0 || nid >= MAX_NUMNODES || !node_online(nid))
> [ replaced with VM_WARN_ON(!node_online(nid)) recently ] in linux/gfp.h
> This patch disables numa affinity in this case.
>
> Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>

...

> diff --git a/net/openvswitch/flow_table.c b/net/openvswitch/flow_table.c
> index f2ea83ba4763..c7f74aab34b9 100644
> --- a/net/openvswitch/flow_table.c
> +++ b/net/openvswitch/flow_table.c
> @@ -93,7 +93,8 @@ struct sw_flow *ovs_flow_alloc(void)
>
>   	/* Initialize the default stat node. */
>   	stats = kmem_cache_alloc_node(flow_stats_cache,
> -				      GFP_KERNEL | __GFP_ZERO, 0);
> +				      GFP_KERNEL | __GFP_ZERO,
> +				      node_online(0) ? 0 : NUMA_NO_NODE);

Stupid question: can node 0 become offline between this check, and the 
VM_WARN_ON? :) BTW what kind of system has node 0 offline?

>   	if (!stats)
>   		goto err;
>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] ovs: do not allocate memory from offline numa node Konstantin Khlebnikov <khlebnikov@yandex-team.ru> - 2015-10-02 12:20 +0200
  Re: [PATCH] ovs: do not allocate memory from offline numa node Pravin Shelar <pshelar@nicira.com> - 2015-10-03 00:40 +0200
  Re: [PATCH] ovs: do not allocate memory from offline numa node David Miller <davem@davemloft.net> - 2015-10-05 15:30 +0200
  Re: [PATCH] ovs: do not allocate memory from offline numa node Vlastimil Babka <vbabka@suse.cz> - 2015-10-05 16:00 +0200
    Re: [PATCH] ovs: do not allocate memory from offline numa node Alexander Duyck <alexander.duyck@gmail.com> - 2015-10-05 22:30 +0200
      Re: [ovs-dev] [PATCH] ovs: do not allocate memory from offline numa node Jesse Gross <jesse@nicira.com> - 2015-10-07 03:10 +0200
        Re: [ovs-dev] [PATCH] ovs: do not allocate memory from offline numa node Jarno Rajahalme <jrajahalme@nicira.com> - 2015-10-07 19:50 +0200
          Re: [ovs-dev] [PATCH] ovs: do not allocate memory from offline numa node Jesse Gross <jesse@nicira.com> - 2015-10-09 01:10 +0200
            Re: [ovs-dev] [PATCH] ovs: do not allocate memory from offline numa node Jesse Gross <jesse@nicira.com> - 2015-10-10 00:20 +0200

csiph-web