Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1239562
| From | "David B. Robins" <linux@davidrobins.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] net: usb: asix: Fix crash on skb alloc failure |
| Date | 2015-10-05 15:30 +0200 |
| Message-ID | <qge02-85-21@gated-at.bofh.it> (permalink) |
| References | <qevRo-6TJ-13@gated-at.bofh.it> <qgb2b-4nd-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 2015-10-05 06:31, David Miller wrote: > From: "David B. Robins" <linux@davidrobins.net> > Date: Wed, 30 Sep 2015 16:20:04 -0400 > >> If asix_rx_fixup_internal() fails to allocate rx->ax_skb, it will >> return >> but not clear rx->size. rx points to driver private data. A later call >> assumes that nonzero size means ax_skb was allocated and passes a null >> ax_skb to skb_put. Changed allocation failure return to clear size >> first. >> >> Found testing board with AX88772B devices. >> >> Signed-off-by: David B. Robins <linux@davidrobins.net> > > Applied, thanks. While I am happy for the patch I submitted to be applied, and it is consistent with existing error handling and does fix the specific issue, I believe a later series of 5 patches by Dean Jenkins that more comprehensively address the issue (grouped under subject "Improve ASIX RX memory allocation error handling") should be preferred. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH] net: usb: asix: Fix crash on skb alloc failure "David B. Robins" <linux@davidrobins.net> - 2015-09-30 22:10 +0200
Re: [PATCH] net: usb: asix: Fix crash on skb alloc failure David Miller <davem@davemloft.net> - 2015-10-05 12:20 +0200
Re: [PATCH] net: usb: asix: Fix crash on skb alloc failure "David B. Robins" <linux@davidrobins.net> - 2015-10-05 15:30 +0200
csiph-web