[PATCH v2 2/3] sched/core: drop unlikely behind BUG_ON()

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Geliang Tang <geliangtang@163.com>
Newsgroups	linux.kernel
Subject	[PATCH v2 2/3] sched/core: drop unlikely behind BUG_ON()
Date	Mon, 05 Oct 2015 15:30:02 +0200
Message-ID	<qge02-85-11@gated-at.bofh.it> (permalink)
References	<qge01-85-1@gated-at.bofh.it>
X-Original-To	Ingo Molnar <mingo@redhat.com>, Peter Zijlstra <peterz@infradead.org>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=OL42rEuYoUv+/jD5gQ nH8k3wRlp67v0WyfPoGLBpPgc=; b=ZAIN/zMXYKN/lVZMT3GIFfYi5sa6ri8btV umLOedmzLAWbMdQMxZwZKH02gV/tWnVlRh+symXXdp9+w1ep/TSHdilHhtzyeY9A CJwzfy2/obIuLFX0AyGCoPxUKZkfpYy5M7bBmkc5meDMZjTibjld705k+MnLo6Uj w6jvv6F04=
X-Mailer	git-send-email 2.5.0
X-Cm-Transid	D9GowACHn0t+ehJWeay_Cw--.14791S3
X-Coremail-Antispam	1Uf129KBjvJXoW7Xw1UXF4xtF18Aw1UWr1fXrb_yoW8Jr4fpr 97Wws7GanrGa4vka48Zrn7u345Kwn5C347WFs5KryrArn8K3ySqr1Fq3ZxCF1093yjgrya qFs2vr17tw1UAwUanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07Uo89NUUUUU=
X-Originating-IP	[116.77.145.2]
X-Cm-Senderinfo	5jhoxtpqjwt0rj6rljoofrz/1tbiNR+KmVSIJSGNXQAAsx
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	44
Organization	linux.* mail to news gateway
X-Original-Cc	Geliang Tang <geliangtang@163.com>, linux-kernel@vger.kernel.org
X-Original-Date	Mon, 5 Oct 2015 21:26:05 +0800
X-Original-Message-ID	<6fa7125979f98bbeac26e268271769b6ca935c8d.1444051018.git.geliangtang@163.com>
X-Original-References	<482d18783d6df356809b67431de95addfa20aa79.1444051018.git.geliangtang@163.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1239557

Show key headers only | View raw

(1) For !CONFIG_BUG cases, the bug call is a no-op, so we couldn't care
less and the change is ok.

(2) ppc and mips, which HAVE_ARCH_BUG_ON, do not rely on branch predictions
as it seems to be pointless[1] and thus callers should not be trying to
push an optimization in the first place.

(3) For CONFIG_BUG and !HAVE_ARCH_BUG_ON cases, BUG_ON() contains an
unlikely compiler flag already.

Hence, we can drop unlikely behind BUG_ON().

[1] http://lkml.iu.edu/hypermail/linux/kernel/1101.3/02289.html

Signed-off-by: Geliang Tang <geliangtang@163.com>
---
Changes in v2:
 - Just rewrite the commit log.
---
 kernel/sched/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index fe81929..a3518789 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -2947,7 +2947,7 @@ static noinline void __schedule_bug(struct task_struct *prev)
 static inline void schedule_debug(struct task_struct *prev)
 {
 #ifdef CONFIG_SCHED_STACK_END_CHECK
-	BUG_ON(unlikely(task_stack_end_corrupted(prev)));
+	BUG_ON(task_stack_end_corrupted(prev));
 #endif
 	/*
 	 * Test if we are atomic. Since do_exit() needs to call into
-- 
2.5.0


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH v2 1/3] scsi: drop unlikely behind BUG_ON() Geliang Tang <geliangtang@163.com> - 2015-10-05 15:30 +0200
  [PATCH v2 2/3] sched/core: drop unlikely behind BUG_ON() Geliang Tang <geliangtang@163.com> - 2015-10-05 15:30 +0200
    [tip:sched/core] sched/core: Drop unlikely behind BUG_ON() tip-bot for Geliang Tang <tipbot@zytor.com> - 2015-10-06 18:20 +0200
  [PATCH v2 3/3] mm/nommu: drop unlikely behind BUG_ON() Geliang Tang <geliangtang@163.com> - 2015-10-05 15:40 +0200

csiph-web