Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1239551
| From | Mark Rutland <mark.rutland@arm.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH V2 1/2] Documentation: DT: Add binding documentation for NVIDIA ADMA |
| Date | 2015-10-05 15:20 +0200 |
| Message-ID | <qgdQn-8oB-31@gated-at.bofh.it> (permalink) |
| References | <qgcUh-73G-3@gated-at.bofh.it> <qgcUi-73G-19@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, Oct 05, 2015 at 01:10:06PM +0100, Jon Hunter wrote:
> Add device-tree binding documentation for the Tegra210 Audio DMA
> controller.
>
> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
> ---
> .../devicetree/bindings/dma/tegra210-adma.txt | 63 ++++++++++++++++++++++
> 1 file changed, 63 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/dma/tegra210-adma.txt
>
> diff --git a/Documentation/devicetree/bindings/dma/tegra210-adma.txt b/Documentation/devicetree/bindings/dma/tegra210-adma.txt
> new file mode 100644
> index 000000000000..df0e46868a63
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/dma/tegra210-adma.txt
> @@ -0,0 +1,63 @@
> +* NVIDIA Tegra Audio DMA (ADMA) controller
> +
> +Required properties:
> +- compatible: Must be "nvidia,tegra210-adma".
> +- reg: Should contain DMA registers location and length. This should be
> + a single entry that includes all of the per-channel registers in one
> + contiguous bank.
> +- interrupt-parent: Phandle to the interrupt parent controller.
> +- interrupts: Should contain all of the per-channel DMA interrupts in
> + ascending order with respect to the DMA channel index.
> +- clocks: Must contain one entry for the ADMA module clock, "adma_ape".
> +- clock-names: Must contain the entry "adma_ape".
> +- dma-channels: Must be 22. Defines the number of DMA channels supported
> + by the DMA controller.
If this has to be a fixed value, why is it necessary? Why does the
driver not just know this?
Are there other instances of this IP block where this differs?
> +- dma-rx-requests: Must be 10. Defines the number of receive request
> + signals supported by the DMA controller.
> +- dma-tx-requests: Must be 10. Defines the number of transmit request
> + signals supported by the DMA controller.
Likewise for these two?
Mark.
> +- #dma-cells : Must be <2>. The first cell denotes the transmit or
> + receive request number and should be between 1 and the maximum number
> + of requests supported (see properties "dma-rx-requests" and
> + "dma-tx-requests"). This value corresponds to the RX/TX_REQUEST_SELECT
> + fields in the ADMA_CHn_CTRL register. The second cell denotes whether
> + the channel is a receive or transmit channel and must be either 2 for
> + a receive channel and 4 for a transmit channel. These values correspond
> + to the TRANSFER_DIRECTION field of the ADMA_CHn_CTRL register.
> +
> +
> +Example:
> +
> +adma: adma@702e2000 {
> + compatible = "nvidia,tegra210-adma";
> + reg = <0x0 0x702e2000 0x0 0x2000>;
> + interrupt-parent = <&tegra_agic>;
> + interrupts = <GIC_SPI INT_ADMA_EOT0 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI INT_ADMA_EOT1 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI INT_ADMA_EOT2 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI INT_ADMA_EOT3 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI INT_ADMA_EOT4 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI INT_ADMA_EOT5 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI INT_ADMA_EOT6 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI INT_ADMA_EOT7 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI INT_ADMA_EOT8 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI INT_ADMA_EOT9 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI INT_ADMA_EOT10 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI INT_ADMA_EOT11 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI INT_ADMA_EOT12 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI INT_ADMA_EOT13 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI INT_ADMA_EOT14 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI INT_ADMA_EOT15 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI INT_ADMA_EOT16 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI INT_ADMA_EOT17 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI INT_ADMA_EOT18 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI INT_ADMA_EOT19 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI INT_ADMA_EOT20 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI INT_ADMA_EOT21 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&tegra_car TEGRA210_CLK_ADMA_APE>;
> + clock-names = "adma_ape";
> + dma-channels = <22>;
> + dma-rx-requests = <10>;
> + dma-tx-requests = <10>;
> + #dma-cells = <2>;
> +};
> --
> 2.1.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH V2 0/2] Add support for Tegra210 ADMA Jon Hunter <jonathanh@nvidia.com> - 2015-10-05 14:20 +0200
[PATCH V2 1/2] Documentation: DT: Add binding documentation for NVIDIA ADMA Jon Hunter <jonathanh@nvidia.com> - 2015-10-05 14:20 +0200
Re: [PATCH V2 1/2] Documentation: DT: Add binding documentation for NVIDIA ADMA Mark Rutland <mark.rutland@arm.com> - 2015-10-05 15:20 +0200
Re: [PATCH V2 1/2] Documentation: DT: Add binding documentation for NVIDIA ADMA Jon Hunter <jonathanh@nvidia.com> - 2015-10-06 11:20 +0200
Re: [PATCH V2 1/2] Documentation: DT: Add binding documentation for NVIDIA ADMA Stephen Warren <swarren@wwwdotorg.org> - 2015-10-07 01:00 +0200
Re: [PATCH V2 1/2] Documentation: DT: Add binding documentation for NVIDIA ADMA Jon Hunter <jonathanh@nvidia.com> - 2015-10-07 17:30 +0200
Re: [PATCH V2 1/2] Documentation: DT: Add binding documentation for NVIDIA ADMA Stephen Warren <swarren@wwwdotorg.org> - 2015-10-07 18:10 +0200
Re: [PATCH V2 1/2] Documentation: DT: Add binding documentation for NVIDIA ADMA Mark Rutland <mark.rutland@arm.com> - 2015-10-07 18:40 +0200
Re: [PATCH V2 1/2] Documentation: DT: Add binding documentation for NVIDIA ADMA Stephen Warren <swarren@wwwdotorg.org> - 2015-10-07 01:10 +0200
Re: [PATCH V2 1/2] Documentation: DT: Add binding documentation for NVIDIA ADMA Jon Hunter <jonathanh@nvidia.com> - 2015-10-07 10:50 +0200
Re: [PATCH V2 1/2] Documentation: DT: Add binding documentation for NVIDIA ADMA Stephen Warren <swarren@wwwdotorg.org> - 2015-10-07 18:10 +0200
Re: [PATCH V2 1/2] Documentation: DT: Add binding documentation for NVIDIA ADMA Jon Hunter <jonathanh@nvidia.com> - 2015-10-07 18:30 +0200
Re: [PATCH V2 1/2] Documentation: DT: Add binding documentation for NVIDIA ADMA Stephen Warren <swarren@wwwdotorg.org> - 2015-10-07 21:40 +0200
Re: [PATCH V2 1/2] Documentation: DT: Add binding documentation for NVIDIA ADMA Jon Hunter <jonathanh@nvidia.com> - 2015-10-08 12:00 +0200
Re: [PATCH V2 1/2] Documentation: DT: Add binding documentation for NVIDIA ADMA Stephen Warren <swarren@wwwdotorg.org> - 2015-10-08 16:30 +0200
Re: [PATCH V2 1/2] Documentation: DT: Add binding documentation for NVIDIA ADMA Jon Hunter <jonathanh@nvidia.com> - 2015-10-09 12:30 +0200
Re: [PATCH V2 1/2] Documentation: DT: Add binding documentation for NVIDIA ADMA Stephen Warren <swarren@wwwdotorg.org> - 2015-10-09 17:30 +0200
Re: [PATCH V2 1/2] Documentation: DT: Add binding documentation for NVIDIA ADMA Jon Hunter <jonathanh@nvidia.com> - 2015-10-12 16:00 +0200
Re: [PATCH V2 1/2] Documentation: DT: Add binding documentation for NVIDIA ADMA Stephen Warren <swarren@wwwdotorg.org> - 2015-10-12 20:00 +0200
Re: [PATCH V2 1/2] Documentation: DT: Add binding documentation for NVIDIA ADMA Jon Hunter <jonathanh@nvidia.com> - 2015-10-13 15:00 +0200
Re: [PATCH V2 1/2] Documentation: DT: Add binding documentation for NVIDIA ADMA Mark Rutland <mark.rutland@arm.com> - 2015-10-07 18:40 +0200
[PATCH V2 2/2] dmaengine: tegra-adma: Add support for Tegra210 ADMA Jon Hunter <jonathanh@nvidia.com> - 2015-10-05 14:20 +0200
Re: [PATCH V2 2/2] dmaengine: tegra-adma: Add support for Tegra210 ADMA Arnd Bergmann <arnd@arndb.de> - 2015-10-06 11:40 +0200
Re: [PATCH V2 2/2] dmaengine: tegra-adma: Add support for Tegra210 ADMA Jon Hunter <jonathanh@nvidia.com> - 2015-10-06 11:50 +0200
Re: [PATCH V2 2/2] dmaengine: tegra-adma: Add support for Tegra210 ADMA Vinod Koul <vinod.koul@intel.com> - 2015-10-14 13:30 +0200
Re: [PATCH V2 2/2] dmaengine: tegra-adma: Add support for Tegra210 ADMA Jon Hunter <jonathanh@nvidia.com> - 2015-10-14 15:40 +0200
csiph-web