Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1239470

Re: [PATCH v2 2/3] iio:adc:palmas: add DT support

Show all headers | View raw

On Sun, Oct 04, 2015 at 06:05:59PM +0200, H. Nikolaus Schaller wrote:
> From: Marek Belisko <marek@goldelico.com>
> 
> Code was found at:
> https://android.googlesource.com/kernel/tegra/+/a90856a6626d502d42c6e7abccbdf9d730b36270%5E%21/#F1
> 
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> [Fixed minor typos + add channels list to documentation]
> Signed-off-by: Marek Belisko <marek@goldelico.com>
> ---
> .../devicetree/bindings/iio/adc/palmas-gpadc.txt   | 46 +++++++++++++++++++
> drivers/iio/adc/palmas_gpadc.c                     | 52 +++++++++++++++++++---
> 2 files changed, 93 insertions(+), 5 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/iio/adc/palmas-gpadc.txt
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/palmas-gpadc.txt b/Documentation/devicetree/bindings/iio/adc/palmas-gpadc.txt
> new file mode 100644
> index 0000000..2149afe
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/palmas-gpadc.txt
> @@ -0,0 +1,46 @@
> +* Palmas general purpose ADC IP block devicetree bindings
> +
> +Channels list:
> +	0 battery type
> +	1 battery temp NTC (optional current source)
> +	2 GP
> +	3 temp (with ext. diode, optional current source)
> +	4 GP
> +	5 GP
> +	6 VBAT_SENSE
> +	7 VCC_SENSE
> +	8 Backup Battery voltage
> +	9 external charger (VCHG)
> +	10 VBUS
> +	11 DC-DC current probe (how does this work?)
> +	12 internal die temp
> +	13 internal die temp
> +	14 USB ID pin voltage
> +	15 test network
> +
> +Required properties:
> +- compatible : Must be "ti,palmas-gpadc".
> +
> +Optional sub-nodes:
> +ti,channel0-current-microamp: Channel 0 current in uA.
> +	Values are rounded to derive 0uA, 5uA, 15uA, 20uA.
> +ti,channel3-current-microamp: Channel 3 current in uA.
> +	Valid are rounded to derive 0uA, 10uA, 400uA, 800uA.

It's only possible to configure channels 0 and 3 in this manner?

> +ti,enable-extended-delay: Enable extended delay.

What is this? When would I select it? Why does it belong in the DT
rather than being a runtime option?

> +Example:
> +
> +pmic {
> +	compatible = "ti,twl6035-pmic", "ti,palmas-pmic";
> +	...
> +	gpadc {
> +		compatible = "ti,palmas-gpadc";
> +		interrupts = <18 0
> +			      16 0
> +			      17 0>;
> +		ti,channel0-current-microamp = <5>;
> +		ti,channel3-current-microamp = <10>;
> +		};
> +	};
> +	...
> +};

I thought you needed #iio-cells for encoding the channel?

Mark.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] Add Palmas iio gpadc "H. Nikolaus Schaller" <hns@goldelico.com> - 2015-09-23 14:50 +0200
  [PATCH v2 1/3] iio:adc: add iio driver for Palmas (twl6035/7) gpadc "H. Nikolaus Schaller" <hns@goldelico.com> - 2015-10-04 18:10 +0200
  [PATCH v2 0/3] Add Palmas iio gpadc "H. Nikolaus Schaller" <hns@goldelico.com> - 2015-10-05 08:20 +0200
    [PATCH v2 2/3] iio:adc:palmas: add DT support "H. Nikolaus Schaller" <hns@goldelico.com> - 2015-10-05 08:20 +0200
      Re: [PATCH v2 2/3] iio:adc:palmas: add DT support Laxman Dewangan <ldewangan@nvidia.com> - 2015-10-05 13:10 +0200
    [PATCH v2 1/3] iio:adc: add iio driver for Palmas (twl6035/7) gpadc "H. Nikolaus Schaller" <hns@goldelico.com> - 2015-10-05 08:20 +0200
      Re: [PATCH v2 1/3] iio:adc: add iio driver for Palmas (twl6035/7)  gpadc kbuild test robot <lkp@intel.com> - 2015-10-05 09:00 +0200
      [PATCH] iio:adc: fix platform_no_drv_owner.cocci warnings kbuild test robot <lkp@intel.com> - 2015-10-05 09:00 +0200
      Re: [PATCH v2 1/3] iio:adc: add iio driver for Palmas (twl6035/7)  gpadc Laxman Dewangan <ldewangan@nvidia.com> - 2015-10-05 13:00 +0200
    [PATCH v2 3/3] ARM: dts: omap5-uevm: enable iio gpadc for Palmas "H. Nikolaus Schaller" <hns@goldelico.com> - 2015-10-05 08:20 +0200
  Re: [PATCH v2 2/3] iio:adc:palmas: add DT support Mark Rutland <mark.rutland@arm.com> - 2015-10-05 13:20 +0200
    Re: [PATCH v2 2/3] iio:adc:palmas: add DT support "H. Nikolaus Schaller" <hns@goldelico.com> - 2015-10-05 16:30 +0200

csiph-web