Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1239422

Re: [PATCH] staging: dgap: remove unused configuration

Show all headers | View raw

On Mon, Oct 05, 2015 at 12:46:43PM +0300, Dan Carpenter wrote:
> On Sun, Oct 04, 2015 at 09:19:20PM +0530, Sudip Mukherjee wrote:
> > The IO configuration was not used to configure the board. It was only
> > read from the configuration file. Stop reading it and also remove the
> > other related variables defined for it.
> > 
> > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> 
> But say someone has an old config file with IO in it, doesn't this break
> their system?
No, it should not. dgap_parsefile() is executing a loop and reading
tokens from the configuration file and depending on what token it has
read it will do switch-case. And it will not find case IO: anymore and
will be just ignored (there is no default:).

And this is actually just a first step towards removing the
configuration file as Greg was telling that loading a firmware file and
consideing it as a configuartion file is not the right thing to do. So I
am removing all the unused configurations one at a time and after they
are removed then depending on the configurations left I will ask for
your suggestion how to remove the use of configuration file.

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] staging: dgap: remove unused configuration Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-10-04 18:00 +0200
  Re: [PATCH] staging: dgap: remove unused configuration Dan Carpenter <dan.carpenter@oracle.com> - 2015-10-05 11:50 +0200
    Re: [PATCH] staging: dgap: remove unused configuration Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-10-05 12:20 +0200

csiph-web