Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1239392

Re: [PATCH] ASoC: sun4i-codec: Rework and fix headphone routing

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Sun, Oct 04, 2015 at 03:38:16PM +0200, Maxime Ripard wrote:

> Most of the boards have their headphone jack directly connected to the
> matching pins of the SoCs. Since most of the time we will have the same
> routing path, it makes sense to put that in the driver, and only have a
> property describing whether that route is enabled or not.

What is the value in having just a dumb jack with no detection
configured?  It doesn't actually do anything...

> It also fixes the following warning messages that were seen so far:
> sun4i-codec 1c22c00.codec: ASoC: no sink widget found for Headphone Jack
> sun4i-codec 1c22c00.codec: ASoC: Failed to add route HP Left -> direct -> Headphone Jack
> sun4i-codec 1c22c00.codec: ASoC: no sink widget found for Headphone Jack
> sun4i-codec 1c22c00.codec: ASoC: Failed to add route HP Right -> direct -> Headphone Jack

Why are these routes being added separately to adding the jack?  Just
remove the broken routes.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] ASoC: sun4i-codec: Rework and fix headphone routing Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-10-04 15:40 +0200
  Re: [PATCH] ASoC: sun4i-codec: Rework and fix headphone routing Mark Brown <broonie@kernel.org> - 2015-10-05 11:50 +0200
    Re: [PATCH] ASoC: sun4i-codec: Rework and fix headphone routing Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-10-05 12:30 +0200
      Re: [PATCH] ASoC: sun4i-codec: Rework and fix headphone routing Mark Brown <broonie@kernel.org> - 2015-10-05 16:30 +0200

csiph-web