Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1241482

Re: [PATCH] IB/core: avoid 32-bit warning

Show all headers | View raw

On 10/7/2015 3:29 PM, Arnd Bergmann wrote:
> The INIT_UDATA() macro requires a pointer or unsigned long argument for
> both input and output buffer, and all callers had a cast from when
> the code was merged until a recent restructuring, so now we get
>
> core/uverbs_cmd.c: In function 'ib_uverbs_create_cq':
> core/uverbs_cmd.c:1481:66: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>
> This makes the code behave as before by adding back the cast to
> unsigned long.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 565197dd8fb1 ("IB/core: Extend ib_uverbs_create_cq")
>
> diff --git a/drivers/infiniband/core/uverbs_cmd.c b/drivers/infiniband/core/uverbs_cmd.c
> index be4cb9f04be3..88b3b78340f2 100644
> --- a/drivers/infiniband/core/uverbs_cmd.c
> +++ b/drivers/infiniband/core/uverbs_cmd.c
> @@ -1478,7 +1478,7 @@ ssize_t ib_uverbs_create_cq(struct ib_uverbs_file *file,
>   	if (copy_from_user(&cmd, buf, sizeof(cmd)))
>   		return -EFAULT;
>
> -	INIT_UDATA(&ucore, buf, cmd.response, sizeof(cmd), sizeof(resp));
> +	INIT_UDATA(&ucore, buf, (unsigned long)cmd.response, sizeof(cmd), sizeof(resp));

Would it make sense to cast inside INIT_UDATA() and not have callers
worry about it?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] IB/core: avoid 32-bit warning Arnd Bergmann <arnd@arndb.de> - 2015-10-07 14:40 +0200
  Re: [PATCH] IB/core: avoid 32-bit warning Yann Droneaud <ydroneaud@opteya.com> - 2015-10-07 15:10 +0200
  Re: [PATCH] IB/core: avoid 32-bit warning Sagi Grimberg <sagig@dev.mellanox.co.il> - 2015-10-07 15:20 +0200
    Re: [PATCH] IB/core: avoid 32-bit warning Arnd Bergmann <arnd@arndb.de> - 2015-10-07 15:50 +0200
    Re: [PATCH] IB/core: avoid 32-bit warning Yann Droneaud <ydroneaud@opteya.com> - 2015-10-07 15:50 +0200

csiph-web