Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1241478

Re: [PATCH v2 1/3] nvmem: core: make default user binary file root-access only

Show all headers | View raw

On 07/10/15 13:55, Greg KH wrote:
> On Wed, Oct 07, 2015 at 12:00:47PM +0100, Srinivas Kandagatla wrote:
>> As required by many providers like at24/at25/mxs-ocotp/qfprom and may be
>> other providers would want to allow root-only to read the nvmem content.
>> So making the defaults to be root-only access would address the request
>> and also provide flexibility to providers to specify there own permissions
>> on top of the root-only using the perm flag in nvmem_config.
>
> Eeek, no, don't mess with different permissions, that's not ok, be
> consistent and only allow root write access, that's why we have static
> build-time checks to ensure you get this correct and do not accidentally
> let a "normal" user access to things they shouldn't have access to.
Thanks for your inputs,

Code as it is in mainline would provide a write permission to root-only 
and read to all the group.

Fixing/removing the group read permissions should stop normal user 
accessing the binary file.


--srini
>
>> Making this dynamic did cut down lot of static binary attributes in the
>> code.
>
> Nothing wrong with static binary attributes, please use them instead.
>
> thanks,
>
> greg k-h
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/3] nvmem: make sysfs binary file permissions more flexible. Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2015-10-07 13:10 +0200
  [PATCH v2 1/3] nvmem: core: make default user binary file root-access only Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2015-10-07 13:10 +0200
    Re: [PATCH v2 1/3] nvmem: core: make default user binary file  root-access only Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-10-07 13:40 +0200
      Re: [PATCH v2 1/3] nvmem: core: make default user binary file root-access  only Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2015-10-07 15:50 +0200
        Re: [PATCH v2 1/3] nvmem: core: make default user binary file  root-access only Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-10-07 18:30 +0200
    Re: [PATCH v2 1/3] nvmem: core: make default user binary file  root-access only Greg KH <gregkh@linuxfoundation.org> - 2015-10-07 15:00 +0200
      Re: [PATCH v2 1/3] nvmem: core: make default user binary file root-access  only Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2015-10-07 15:20 +0200
        Re: [PATCH v2 1/3] nvmem: core: make default user binary file  root-access only Greg KH <gregkh@linuxfoundation.org> - 2015-10-07 18:20 +0200

csiph-web