Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1241079

Re: [PATCH 09/11] clocksource: add TI 32.768 Hz counter driver

Show all headers | View raw

On 10/06/2015 07:02 PM, Felipe Balbi wrote:
> Introduce a new clocksource driver for Texas
> Instruments 32.768 Hz device which is available
> on most OMAP-like devices.
>
> Signed-off-by: Felipe Balbi <balbi@ti.com>

Hi Felipe,

With the couple of nits below fixed, you can my:

Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>

[ ... ]

> +#define OMAP2_32KSYNCNT_REV_OFF		0x0
> +#define OMAP2_32KSYNCNT_REV_SCHEME	(0x3 << 30)
> +#define OMAP2_32KSYNCNT_CR_OFF_LOW	0x10
> +#define OMAP2_32KSYNCNT_CR_OFF_HIGH	0x30
> +
> +struct ti_32k {
> +	void __iomem		*base;
> +	void __iomem		*counter;
> +	struct clocksource	cs;
> +};
> +#define to_ti_32k(cs)	(container_of((cs), struct ti_32k, cs))

Usually a static inline is used instead of a macro for that.

> +static cycle_t ti_32k_read_cycles(struct clocksource *cs)
> +{
> +	struct ti_32k		*ti = to_ti_32k(cs);

format


-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/11] arm: omap: counter32k rework Felipe Balbi <balbi@ti.com> - 2015-10-06 19:10 +0200
  [PATCH 07/11] arm: omap2: timer: remove omap4_local_timer_init Felipe Balbi <balbi@ti.com> - 2015-10-06 19:10 +0200
  [PATCH 04/11] arm: omap2: timer: provide generic sync32k_timer_init function Felipe Balbi <balbi@ti.com> - 2015-10-06 19:10 +0200
    Re: [PATCH 04/11] arm: omap2: timer: provide generic  sync32k_timer_init function Suman Anna <s-anna@ti.com> - 2015-10-06 20:40 +0200
      Re: [PATCH 04/11] arm: omap2: timer: provide generic sync32k_timer_init function Felipe Balbi <balbi@ti.com> - 2015-10-06 21:20 +0200
  [PATCH 02/11] arm: omap2: timer: add a gptimer argument to sync32k_timer_init() Felipe Balbi <balbi@ti.com> - 2015-10-06 19:10 +0200
  [PATCH 06/11] arm: omap2: timer: always call clocksource_of_init() when DT Felipe Balbi <balbi@ti.com> - 2015-10-06 19:10 +0200
  [PATCH 09/11] clocksource: add TI 32.768 Hz counter driver Felipe Balbi <balbi@ti.com> - 2015-10-06 19:10 +0200
    Re: [PATCH 09/11] clocksource: add TI 32.768 Hz counter driver Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-10-07 01:30 +0200
      Re: [PATCH 09/11] clocksource: add TI 32.768 Hz counter driver Felipe Balbi <balbi@TI.COM> - 2015-10-07 05:10 +0200

csiph-web